1827416 - update stackwalker to v0.16.0

Status: RESOLVED FIXED

(Socorro :: Processor, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

We need to update the stackwalker to v0.16.0:

https://github.com/rust-minidump/rust-minidump/releases/tag/v0.16.0

We're currently running socorro-stackwalker.2022-11-30.v0.15.0.tar.gz.

Comment 1

[Gabriele Svelto [:gsvelto]]

Compared to the old release we added two new fields under the crash_info field:

1. adjusted_address that indicates the stackwalker considers the crashing address a different one from the one in the address field
2. possible_bit_flips that contains information about potential bit-flips

We'll hash out how to use the second field in separate bugs but we need to adjust Socorro to deal with the first one before we update. I'm filing a separate bug for that and I'll block this one.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6: bug 1827416: update stackwalker to v0.16.0

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I started testing out the new stackwalker and hit an issue. Looks like stackwalker v0.16.0 changed the type for cpu_microcode_version:

https://github.com/rust-minidump/rust-minidump/issues/836

Alex said the type change is intentional. I don't know if the type waffles depending on the source, but it probably doesn't. I'll do a PR to fix the json_schema.md file and also the release notes.

Then I need to look at how Socorro handles that field and fix it to handle the new type. It's possible we can just switch the type. It's also possible we have to support both the old and new types for a while until data expires.

Once I'm done with that, I'll go back to looking for other issues.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I did a PR to update the schema and release notes for rust-minidump:

https://github.com/rust-minidump/rust-minidump/pull/841

Comment 5

[Gabriele Svelto [:gsvelto]]

Thanks a lot Will, I'm merging it.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6408: bug 1827416, 1827495: update stackwalker to v0.16.0; add support for adjusted_address

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6408: "bug 1827416, 1827495: update stackwalker to v0.16.0; add support for adjusted_address" in ec5492c.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this to prod just now with bug #1833850. Marking as FIXED.

Comment 9

[Gabriele Svelto [:gsvelto]]

Cool, thanks!