Closed Bug 1827572 Opened 1 year ago Closed 1 year ago

Impression ping for first screen is always EASY_SETUP instead of actually shown screen

Categories

(Firefox :: Messaging System, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
114 Branch
Iteration:
114.1 - Apr 10 - Apr 21
Tracking Status
firefox-esr102 --- unaffected
firefox112 --- unaffected
firefox113 + verified
firefox114 --- verified

People

(Reporter: sbadau, Assigned: pdahiya)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Found in

  • Firefox 113.0b2

Affected versions

  • Firefox 113 beta
  • Nightly 114.0a1

Tested platforms

  • Affected platforms: Windows 10, macOS 11.7

Preconditions

  • Firefox is set as the default browser and it is pinned to the taskbar/dock;
  • browser.ping-centre.log set to true;
  • Have the "Browser Console" opened.

Steps to reproduce

  1. Navigate to the "about:welcome" page and focus on the "Browser Console".
  2. Observe the displayed pings.

Expected result

  • A telemetry ping specific to the "about:welcome" and the "Get Started" slide should be triggered. It should look like this:

** TELEMETRY PING (about:welcome): {"experiments":{},"locale":"en-US","version":"112.0","release_channel":"release","event":"IMPRESSION","event_context":"{"page":"about:welcome"}","message_id":"MR_WELCOME_DEFAULT_0_AW_GET_STARTED_GLIMG","addon_version":"20230406114409","client_id":"41dee36e-9b18-4665-bde9-d93306a75f76","browser_session_id":"99799259-9c36-4b28-92b5-4d77a2445145"}

Actual result

  • The telemetry ping is triggered but is specific to the "Easy setup" slide. It looks like this:

**TELEMETRY PING (about:welcome): {"experiments":{"beta-ech-validation":{"branch":"enabled-fallbacks"}},"locale":"en-US","version":"113.0","release_channel":"beta","event":"IMPRESSION","event_context":"{"page":"about:welcome"}","message_id":"MR_WELCOME_DEFAULT_0_AW_EASY_SETUP_EGLIMG","addon_version":"20230411180038","client_id":"f7f79348-4654-4655-ac78-62cd4c7236a2","browser_session_id":"b1e3278e-3045-40d6-b8cd-32c56a11b42d","attribution":{"dlsource":"mozillaci"}}

Regression range
This is a recent regression as it is not reproducible on the latest Firefox 112 release. I will look for a regression range as soon as possible.

This is likely a regression from bug 1820566. Both the filtering and sending impression happen at the same time, but we probably want to only send the impression after filtering. This probably also means react is rendering the easy setup screen initially (even on macOS) and very quickly switching it, but we probably also don't want to send 2 impression pings of EASY_SETUP then GET_STARTED

https://searchfox.org/mozilla-central/rev/5f10809bf5559e6e988e4d1a58ce1338d391cc5f/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#25,28,35,37,44-45,57

Iteration: --- → 114.1 - Apr 10 - Apr 21
Priority: -- → P1
Regressed by: 1820566
Summary: Impression ping is not properly triggered on the Get Started Slide → Impression ping for first screen is always EASY_SETUP instead of actually shown screen

:pdahiya, since you are the author of the regressor, bug 1820566, could you take a look?

For more information, please visit auto_nag documentation.

Flags: needinfo?(pdahiya)
Assignee: nobody → pdahiya
Flags: needinfo?(pdahiya)
QA Whiteboard: [qa-regression-triage]

The bug is marked as tracked for firefox113 (beta). However, the bug still has low severity.

:tspurway, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Flags: needinfo?(tspurway)
Pushed by pdahiya@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/96f01a59fe31
Telemetry impression pings should wait for filtered screens r=Mardak

Backed out for causing bc failures in browser_aboutwelcome_multistage_mr.js

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_multistage_mr.js | Uncaught exception in test bound test_aboutwelcome_pin_screen_impression - at chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_multistage_mr.js:108 - TypeError: can't access property "args", impressionSpy.lastCall is null
Flags: needinfo?(pdahiya)

Landed patch after updating patch with fix of intermittent test failure on linux asan

Flags: needinfo?(pdahiya)
Pushed by pdahiya@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4079bf8beac4
Telemetry impression pings should wait for filtered screens r=Mardak
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
Flags: qe-verify+
Regressions: 1828987
Flags: needinfo?(tspurway)

I'd like to see bug 1828987 addressed before uplifting this to Beta given the high frequency of those failures.

Regressions: 1829210

Looks like the fix for bug 1828987 is working. Is this ready for a Beta approval request?

Flags: needinfo?(pdahiya)

@Ryan that's correct Bug 1828987 fix looks good. There is another intermittent reported - Bug 1812050 that possibly connected to 1827572 fix. I have landed its fix this morning , with that merged , will submit uplift request for patches in Bug 1827572, Bug 1828987, Bug 1812050 . Thanks!

Flags: needinfo?(pdahiya)
Regressions: 1812050
Regressions: 1829448
Blocks: 1823779

Comment on attachment 9328246 [details]
Bug 1827572 - Telemetry impression pings should wait for filtered screens

Beta/Release Uplift Approval Request

  • User impact if declined: Impression pings for first screen in Telemetry will have incorrect message id
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See https://bugzilla.mozilla.org/show_bug.cgi?id=1827572#c0
  • List of other uplifts needed: Bug 1828987, Bug 1812050
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Patch adds check to ensure telemetry ping gets sent after filter by screen targeting has completed
  • String changes made/needed: none
  • Is Android affected?: No
Attachment #9328246 - Flags: approval-mozilla-beta?

@Ryan beta uplift request in this patch needs three patches uplifted in order D175293, D175989, D176160. Should I submit beta uplift request for test fixes in Bug 1828987 (patch D175989), Bug 1812050 (patch D176160) in their respective bugs or one uplift request in comment #13 above suffice. Thanks

Flags: needinfo?(ryanvm)

Normally we'd ask for an uplift request in each bug, but seeing as how both of those are test-only changes that don't technically require approval for uplift anyway, just the one here is fine. Thanks for checking!

Flags: needinfo?(ryanvm)

Comment on attachment 9328246 [details]
Bug 1827572 - Telemetry impression pings should wait for filtered screens

Approved for 113.0b8.

Attachment #9328246 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-regression-triage] → [qa-regression-triage][qa-triaged]

Verified on the latest Nightly 114.0a1 and Firefox 113.0b8 - the Impression ping for the first screen has the Get started message - tested on macOS 11.7 and Windows 10x64.

However, I've noticed that on Firefox 113.0b8 the Impression ping with the Get started message is duplicated. Is this expected?

Flags: needinfo?(pdahiya)

(In reply to Simona Badau, Desktop QA from comment #18)

Verified on the latest Nightly 114.0a1 and Firefox 113.0b8 - the Impression ping for the first screen has the Get started message - tested on macOS 11.7 and Windows 10x64.

However, I've noticed that on Firefox 113.0b8 the Impression ping with the Get started message is duplicated. Is this expected?

@Simona thanks for verifying , duplicate impression ping on first screen is a known issue and getting tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1829448

Flags: needinfo?(pdahiya)

(In reply to Punam Dahiya [:pdahiya] from comment #20)

@Simona thanks for verifying , duplicate impression ping on first screen is a known issue and getting tracked in https://bugzilla.mozilla.org/show_bug.cgi?id=1829448

Thank you!
Based on Comment 20, marking this as Verified fixed!

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: