1827604 - The letter after an apostrophe should not be affected by text-transform:capitalize

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1252962#c4 (spinning this off as a separate bug, as it's not really the same issue as bug 1252962 was about).

The change in bug 208789 improved cases like hyphenated words ("helter-skelter") or period-separated words or letters ("what.three.words", "c.a.g.e."), but we should exclude apostrophe (both the ASCII apostrophe U+0027 and the "curly" Unicode version U+2019) from the heuristics there.

Comment 1

[krystian3w]

Attachment: Demo

Interactive demo

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 208789

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1827604 - Special-case the apostrophe characters in text-transform:capitalize heuristics. r=#layout-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fe0b816452a
Special-case the apostrophe characters in text-transform:capitalize heuristics. r=emilio

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4fe0b816452a

Comment 7

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:jfkthame, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Jonathan Kew [:jfkthame]]

Comment on attachment 9328152 [details]
Bug 1827604 - Special-case the apostrophe characters in text-transform:capitalize heuristics. r=#layout-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Poor result of text-transform:capitalize in a few cases
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch to special-case a couple of characters in capitalization processing
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Comment on attachment 9328152 [details]
Bug 1827604 - Special-case the apostrophe characters in text-transform:capitalize heuristics. r=#layout-reviewers

Approved for 113 beta 4, thanks.

Comment 10

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

https://hg.mozilla.org/releases/mozilla-beta/rev/c5cedfab7dfa