Closed Bug 1827634 Opened 11 months ago Closed 10 months ago

PiP urlbar button can show wrong icon

Categories

(Toolkit :: Picture-in-Picture, defect, P3)

defect

Tracking

()

VERIFIED FIXED
114 Branch
Tracking Status
firefox114 --- verified

People

(Reporter: niklas, Assigned: niklas)

References

Details

(Whiteboard: [fidefe-pip3] )

Attachments

(1 file)

If two tabs have the PiP urlbar button visible, the PiP icon can be shown in the wrong direction.

STR:

  1. open a youtube video in 2 tabs so the urlbar button is visible
  2. in tab 1 open a PiP window (the urlbar button icon will update so it now shows the unpip icon)
  3. switch to tab 2.

The icon still shows as unpip even though this tab doesn't have a PiP

Clicking the urlbar button will open a PiP window in this tab even though the icon suggested that the PiP window from tab 1 would be closed on click.

Assignee: nobody → nbaumgardner
Severity: -- → S3
Status: NEW → ASSIGNED
Priority: -- → P3
Whiteboard: [fidefe-pip3]
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9abb98c317d
Update PiP urlbar icon on tab change. r=pip-reviewers,mhowell
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch

I have verified the fix using Nightly 114.0a1 (20230418091934) on Windows 10, MacOS 11 and Ubuntu 20.04.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.