1827634 - PiP urlbar button can show wrong icon

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Niklas Baumgardner [:niklas]]

If two tabs have the PiP urlbar button visible, the PiP icon can be shown in the wrong direction.

STR:

1. open a youtube video in 2 tabs so the urlbar button is visible
2. in tab 1 open a PiP window (the urlbar button icon will update so it now shows the unpip icon)
3. switch to tab 2.

The icon still shows as unpip even though this tab doesn't have a PiP

Clicking the urlbar button will open a PiP window in this tab even though the icon suggested that the PiP window from tab 1 would be closed on click.

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1827634 - Update PiP urlbar icon on tab change. r=#pip-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9abb98c317d
Update PiP urlbar icon on tab change. r=pip-reviewers,mhowell

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/c9abb98c317d

Comment 4

[Peter Magyari (Desktop QA)]

I have verified the fix using Nightly 114.0a1 (20230418091934) on Windows 10, MacOS 11 and Ubuntu 20.04.