Closed Bug 1827883 Opened 2 years ago Closed 2 years ago

Perma /css/css-color/parsing/color-computed-lab.html | Property color value 'lab(calc(NaN) 0 0)' - assert_true: 'lab(calc(NaN) 0 0)' is a supported value for color. expected true got false when Gecko 114 merges to Beta on 2023-05-08

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
114 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox112 --- unaffected
firefox113 --- unaffected
firefox114 + verified

People

(Reporter: chorotan, Assigned: CosminS)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1827883 - Enable layout.css.nan-inf pref to get rid of wpt failures on color-computed-lab.html and color-valid-lab.html. r=emilio
48 bytes, text/x-phabricator-request
Details | Review

[Tracking Requested - why for this release]:

task 2023-04-13T11:32:36.232Z] 11:32:36     INFO - TEST-PASS | /css/css-color/parsing/color-computed-lab.html | Property color value 'lab(0 0 0 / none)' 
[task 2023-04-13T11:32:36.232Z] 11:32:36     INFO - TEST-UNEXPECTED-FAIL | /css/css-color/parsing/color-computed-lab.html | Property color value 'lab(calc(NaN) 0 0)' - assert_true: 'lab(calc(NaN) 0 0)' is a supported value for color. expected true got false
[task 2023-04-13T11:32:36.232Z] 11:32:36     INFO - test_computed_value/<@http://web-platform.test:8000/css/support/computed-testcommon.js:20:16
[task 2023-04-13T11:32:36.232Z] 11:32:36     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2595:25
[task 2023-04-13T11:32:36.232Z] 11:32:36     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-04-13T11:32:36.232Z] 11:32:36     INFO - test_computed_value@http://web-platform.test:8000/css/support/computed-testcommon.js:17:7
[task 2023-04-13T11:32:36.232Z] 11:32:36     INFO - @http://web-platform.test:8000/css/css-color/parsing/color-computed-lab.html:50:20
[task 2023-04-13T11:32:36.234Z] 11:32:36     INFO - 
[task 2023-04-13T11:32:36.234Z] 11:32:36     INFO - TEST-UNEXPECTED-FAIL | /css/css-color/parsing/color-computed-lab.html | Property color value 'lab(calc(0 / 0) 0 0)' - assert_true: 'lab(calc(0 / 0) 0 0)' is a supported value for color. expected true got false
[task 2023-04-13T11:32:36.234Z] 11:32:36     INFO - test_computed_value/<@http://web-platform.test:8000/css/support/computed-testcommon.js:20:16
[task 2023-04-13T11:32:36.234Z] 11:32:36     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2595:25
[task 2023-04-13T11:32:36.234Z] 11:32:36     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-04-13T11:32:36.234Z] 11:32:36     INFO - test_computed_value@http://web-platform.test:8000/css/support/computed-testcommon.js:17:7
[task 2023-04-13T11:32:36.234Z] 11:32:36     INFO - @http://web-platform.test:8000/css/css-color/parsing/color-computed-lab.html:51:20
[task 2023-04-13T11:32:36.246Z] 11:32:36     INFO - ...........
[task 2023-04-13T11:32:36.247Z] 11:32:36     INFO - TEST-PASS | /css/css-color/parsing/color-computed-lab.html | Property color value 'oklab(-0.4 0 0)' 
[task 2023-04-13T11:32:36.248Z] 11:32:36     INFO - TEST-PASS | /css/css-color/parsing/color-computed-lab.html | Property color value 'oklab(0.5 -0.2 0)' 
[task 2023-04-13T11:32:36.249Z] 11:32:36     INFO - TEST-PASS | /css/css-color/parsing/color-computed-lab.html | Property color value 'oklab(0.5 0 -0.2)' 
[task 2023-04-13T11:32:36.249Z] 11:32:36     INFO - TEST-FAIL | /css/css-color/parsing/color-computed-lab.html | Property color value 'oklab(calc(0.5 * 3) calc(0.5 - 1) calc(1.5) / calc(-0.5 + 1))' - assert_array_approx_equals: Numeric parameters are approximately equal. property 0, expected 1 +/- 0.0001, expected 1 but got 1.5
[task 2023-04-13T11:32:36.251Z] 11:32:36     INFO - colorValuesAlmostEqual@http://web-platform.test:8000/css/support/computed-testcommon.js:64:29
[task 2023-04-13T11:32:36.252Z] 11:32:36     INFO - test_computed_value/<@http://web-platform.test:8000/css/support/computed-testcommon.js:29:31
[task 2023-04-13T11:32:36.252Z] 11:32:36     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2595:25
[task 2023-04-13T11:32:36.253Z] 11:32:36     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-04-13T11:32:36.254Z] 11:32:36     INFO - test_computed_value@http://web-platform.test:8000/css/support/computed-testcommon.js:17:7
[task 2023-04-13T11:32:36.254Z] 11:32:36     INFO - @http://web-platform.test:8000/css/css-color/parsing/color-computed-lab.html:68:20
[task 2023-04-13T11:32:36.255Z] 11:32:36     INFO - TEST-PASS | /css/css-color/parsing/color-computed-lab.html | Property color value 'oklab(calc(-0.5 * 3) calc(0.5 + 1) calc(-1.5) / calc(-0.5 * 2))' 
[task 2023-04-13T11:32:36.255Z] 11:32:36     INFO - TEST-PASS | /css/css-color/parsing/color-computed-lab.html | Property color value 'oklab(none none none / none)' 
[task 2023-04-13T11:32:36.256Z] 11:32:36     INFO - TEST-PASS | /css/css-color/parsing/color-computed-lab.html | Property color value 'oklab(none none none)' 
[task 2023-04-13T11:32:36.256Z] 11:32:36     INFO - TEST-PASS | /css/css-color/parsing/color-computed-lab.html | Property color value 'oklab(0.2 none none / none)' 
[task 2023-04-13T11:32:36.256Z] 11:32:36     INFO - TEST-PASS | /css/css-color/parsing/color-computed-lab.html | Property color value 'oklab(none none none / 0.5)' 
[task 2023-04-13T11:32:36.256Z] 11:32:36     INFO - TEST-PASS | /css/css-color/parsing/color-computed-lab.html | Property color value 'oklab(0 0 0 / none)' 
[task 2023-04-13T11:32:36.257Z] 11:32:36     INFO - TEST-UNEXPECTED-FAIL | /css/css-color/parsing/color-computed-lab.html | Property color value 'oklab(calc(NaN) 0 0)' - assert_true: 'oklab(calc(NaN) 0 0)' is a supported value for color. expected true got false
[task 2023-04-13T11:32:36.257Z] 11:32:36     INFO - test_computed_value/<@http://web-platform.test:8000/css/support/computed-testcommon.js:20:16
[task 2023-04-13T11:32:36.257Z] 11:32:36     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2595:25
[task 2023-04-13T11:32:36.257Z] 11:32:36     INFO - test@http://web-platform.test:8000/resources/testharness.js:628:30
[task 2023-04-13T11:32:36.257Z] 11:32:36     INFO - test_computed_value@http://web-platform.test:8000/css/support/computed-testcommon.js:17:7
[task 2023-04-13T11:32:36.257Z] 11:32:36     INFO - @http://web-platform.test:8000/css/css-color/parsing/color-computed-lab.html:77:20
[task 2023-04-13T11:32:36.257Z] 11:32:36     INFO -
Flags: needinfo?(james)
Assignee: nobody → csabou
Status: NEW → ASSIGNED
Attachment #9328526 - Attachment description: Bug 1827883 - Mark color-valid-lab.html and color-computed-lab.html subtests as failing on release or beta. r=emilio,aryx → Bug 1827883 - Enable layout.css.nan-inf pref to ge rid of wpt failures on color-computed-lab.html and color-valid-lab.html. r=emilio
Attachment #9328526 - Attachment description: Bug 1827883 - Enable layout.css.nan-inf pref to ge rid of wpt failures on color-computed-lab.html and color-valid-lab.html. r=emilio → Bug 1827883 - Enable layout.css.nan-inf pref to get rid of wpt failures on color-computed-lab.html and color-valid-lab.html. r=emilio
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/969304f8eb06 Enable layout.css.nan-inf pref to get rid of wpt failures on color-computed-lab.html and color-valid-lab.html. r=emilio

https://hg.mozilla.org/mozilla-central/rev/969304f8eb06

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox114: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch

Verified fixed in today's central as beta sim

Status: RESOLVED → VERIFIED
status-firefox114: fixed → verified
Flags: needinfo?(james)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: