Closed Bug 1827936 Opened 3 years ago Closed 3 years ago

Call AsyncWait after calling EnqueueNative in BodyStream/InputToReadableStreamAlgorithms

Categories

(Core :: DOM: Streams, task)

Product:
Core
Component:
DOM: Streams
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

Attachments

(1 file)

Bug 1827936 - Extract AsyncWait from WriteIntoReadRequestBuffer r=smaug
48 bytes, text/x-phabricator-request
Details | Review

Otherwise EnqueueNative can unexpectedly trigger OnInputStreamReady.

AsyncWait should happen after enqueuing to prevent unwanted synchronous reentrant triggered by JS.

This problem has already been patched by D170867 and D172794 but IMO the call order is the core issue here.

At this point this is more of a refactoring than a real fix.

Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ab99817274ac Extract AsyncWait from WriteIntoReadRequestBuffer r=smaug

https://hg.mozilla.org/mozilla-central/rev/ab99817274ac

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: