Closed
Bug 1828008
Opened 3 years ago
Closed 3 years ago
nsCaret::ResetBlinking creates timers with a delay of UINT32_MAX
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
114 Branch
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(1 file)
The code at https://searchfox.org/mozilla-central/rev/54c533e94ae786056a43231f230c7d9b0773cb80/layout/base/nsCaret.cpp#609,639 expects a blinkRate of 0ms to mean "do not blink", but actually the Windows implementation of getting the CaretBlinkTime value calls ::GetCaretBlinkTime() for which the documentation says "A return value of INFINITE indicates that the caret does not blink."
I think we have another platform where MAX_UINT32 means "do not blink", but I don't remember which one it is.
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/05fc7d57257e
Avoid creating timers with a delay of UINT32_MAX in nsCaret::ResetBlinking, r=emilio.
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox114:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•