1828079 - BackgroundUpdates.sys.mjs should not check for a registry key outside of Windows

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Florian Quèze [:florian]]

At the end of every startup, I see this in my terminal:

console.error: BackgroundUpdate: 
  _reasonsToNotScheduleUpdates: Failed to check for Maintenance Service Registry Key: [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIUpdateProcessor.getServiceRegKeyExists]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: resource://gre/modules/BackgroundUpdate.sys.mjs :: _reasonsToNotScheduleUpdates :: line 251"  data: no]

The documentation says "throws NS_ERROR_NOT_IMPLEMENTED If this is called on a non-Windows platform." so I think this code should check if we are on Windows before doing the call.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1828079 - BackgroundUpdates.sys.mjs should not check for a registry key outside of Windows, r=#application-update-reviewers.

Depends on D174305

Comment 3

[BugBot [:suhaib / :marco]]

The following field has been copied from a duplicate bug:

Field	Value	Source
Regressed by	bug 1705726	bug 1743495

For more information, please visit auto_nag documentation.

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1705726

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81d930c67728
BackgroundUpdates.sys.mjs should not check for a registry key outside of Windows, r=application-update-reviewers,nalexander,bytesized.

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/81d930c67728

Comment 7

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:florian, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox113 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Florian Quèze [:florian]]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #7)

:florian, is this bug important enough to require an uplift?

I would say no, the only user impact is reduced console noise for Mac users.