1828178 - Profiler tests should not fail when MOZ_PROFILER_STARTUP is set in the environment

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P1)

Description

[Florian Quèze [:florian]]

Setting MOZ_PROFILER_STARTUP=1 in the environment is a convenient way to have profiles from try pushes. There are currently 2 profiler tests that fail when doing that:

TEST-UNEXPECTED-FAIL | ipc/glue/test/browser/browser_utility_profiler.js | Uncaught exception in test bound - at chrome://mochitests/content/browser/tools/profiler/tests/browser/shared-head.js:32 - Error: The profiler must not be active before starting it in a test.

TEST-UNEXPECTED-FAIL | tools/profiler/tests/browser/browser_test_feature_ipcmessages.js | The profiler is not currently active - false == true
TEST-UNEXPECTED-FAIL | tools/profiler/tests/browser/browser_test_feature_ipcmessages.js | Uncaught exception in test bound test_profile_feature_ipcmessges - at chrome://mochitests/content/browser/tools/profiler/tests/browser/shared-head.js:32 - Error: The profiler must not be active before starting it in a test.

In my opinions these failures are just noise, and we should silence them.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1828178 - Profiler tests should not fail when MOZ_PROFILER_STARTUP is set in the environment, r=canaltinova.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7889d35d5d7
Profiler tests should not fail when MOZ_PROFILER_STARTUP is set in the environment, r=canaltinova.

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d7889d35d5d7