Closed Bug 1828342 Opened 2 months ago Closed 24 days ago

Current font size in app menu is no longer centered

Categories

(Thunderbird :: Toolbars and Tabs, defect, P3)

Product:
Thunderbird
Component:
Toolbars and Tabs
Type:
defect

Tracking

(thunderbird_esr91 unaffected, thunderbird113 affected, thunderbird114 fixed)

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
thunderbird_esr91 --- unaffected
thunderbird113 --- affected
thunderbird114 --- fixed

People

(Reporter: soeren.hentzschel, Assigned: lejeunealban94)

Details

(Keywords: good-first-bug, polish, regression, Whiteboard: [snnot3p])

Attachments

(3 files)

screenshot
41.50 KB, image/png
Details
Bug 1828342 - fixing centering of fontsizereset button. r=aleca
48 bytes, text/x-phabricator-request
Details | Review
Bug 1828342 - fixing centering of fontsizereset button. r=aleca
48 bytes, text/x-phabricator-request
rjl
: approval-comm-beta+
Details | Review
Attached image screenshot —

STR:

Open the app menu.

Actual:

The current font size is no longer centered.

Expected:

The current font size should be centered, looks wrong as left-aligned field.

Severity: -- → S4
Keywords: good-first-bug, polish
Priority: -- → P3
Summary: current font size in app menu is no longer centered → Current font size in app menu is no longer centered
Whiteboard: [snnot3p]

Is it still the case ? If so I would like to be assigned this issue, it would be my first contribution.

(In reply to Alban LE JEUNE from comment #1)

Is it still the case ? If so I would like to be assigned this issue, it would be my first contribution.

That's great Alban! Yes, it's still the case on Daily 114.0a1 (2023-05-01) (64-bit), Win10.
You can download Daily from thunderbird.net, bottom left corner (e.g. for Windows, current Daily is here).

Please find instructions for building Thunderbird here: https://developer.thunderbird.net/
For this bug, you'll want to go for the artifact builds flavor (which builds only the UI layer, so it's faster).

Richard (:Paenglab) might be able to help when you come to the actual code for this bug.

Assignee: nobody → lejeunealban94
Status: NEW → ASSIGNED

I've built both of the builds and i can't find the thunderbird executable that should be there (even when the terminal is restarted, PC too). If someone have an idea.

And also i've searched for the fontSize button attribute to modify but not found yet

Maybe you have an idea on the subject ?

Flags: needinfo?(richard.marti)

The button is the #appMenu-fontSizeReset-button https://searchfox.org/comm-central/search?q=appMenu-fontSizeReset-button&case=false&regexp=false&path=

Flags: needinfo?(richard.marti)

adding !important rule next to the text-align sufficient to fix this issue ? I'm trying to solve my problem of not being able to build thunderbird, but that's my first idea looking at the code.

ok I've found a solution so now how do I push it ?

Depends on D177300

Keywords: checkin-needed-tb
Target Milestone: --- → 115 Branch

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/fecc8ae2b00f
fixing centering of fontsizereset button. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 24 days ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Comment on attachment 9331916 [details]
Bug 1828342 - fixing centering of fontsizereset button. r=aleca

[Triage Comment]
Approved for beta

Attachment #9331916 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.