Current font size in app menu is no longer centered
Categories
(Thunderbird :: Toolbars and Tabs, defect, P3)
Tracking
(thunderbird_esr91 unaffected, thunderbird113 affected, thunderbird114 fixed)
Tracking | Status | |
---|---|---|
thunderbird_esr91 | --- | unaffected |
thunderbird113 | --- | affected |
thunderbird114 | --- | fixed |
People
(Reporter: soeren.hentzschel, Assigned: lejeunealban94)
Details
(Keywords: good-first-bug, polish, regression, Whiteboard: [snnot3p])
Attachments
(3 files)
STR:
Open the app menu.
Actual:
The current font size is no longer centered.
Expected:
The current font size should be centered, looks wrong as left-aligned field.
Updated•8 months ago
|
Updated•8 months ago
|
Assignee | ||
Comment 1•7 months ago
|
||
Is it still the case ? If so I would like to be assigned this issue, it would be my first contribution.
Comment 2•7 months ago
|
||
(In reply to Alban LE JEUNE from comment #1)
Is it still the case ? If so I would like to be assigned this issue, it would be my first contribution.
That's great Alban! Yes, it's still the case on Daily 114.0a1 (2023-05-01) (64-bit), Win10.
You can download Daily from thunderbird.net, bottom left corner (e.g. for Windows, current Daily is here).
Please find instructions for building Thunderbird here: https://developer.thunderbird.net/
For this bug, you'll want to go for the artifact
builds flavor (which builds only the UI layer, so it's faster).
Richard (:Paenglab) might be able to help when you come to the actual code for this bug.
Updated•7 months ago
|
Assignee | ||
Comment 3•7 months ago
|
||
I've built both of the builds and i can't find the thunderbird executable that should be there (even when the terminal is restarted, PC too). If someone have an idea.
Assignee | ||
Comment 4•7 months ago
|
||
And also i've searched for the fontSize button attribute to modify but not found yet
Assignee | ||
Comment 5•7 months ago
|
||
Maybe you have an idea on the subject ?
Comment 6•7 months ago
|
||
The button is the #appMenu-fontSizeReset-button
https://searchfox.org/comm-central/search?q=appMenu-fontSizeReset-button&case=false®exp=false&path=
Assignee | ||
Comment 7•7 months ago
|
||
adding !important rule next to the text-align sufficient to fix this issue ? I'm trying to solve my problem of not being able to build thunderbird, but that's my first idea looking at the code.
Assignee | ||
Comment 8•7 months ago
|
||
ok I've found a solution so now how do I push it ?
Assignee | ||
Comment 9•7 months ago
|
||
Assignee | ||
Comment 10•7 months ago
|
||
Depends on D177300
Updated•7 months ago
|
Comment 11•7 months ago
|
||
Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/fecc8ae2b00f
fixing centering of fontsizereset button. r=aleca
Comment 12•7 months ago
|
||
Comment on attachment 9331916 [details]
Bug 1828342 - fixing centering of fontsizereset button. r=aleca
[Triage Comment]
Approved for beta
Comment 13•7 months ago
|
||
bugherder uplift |
Thunderbird 114.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/5b8dc09381f2
Description
•