1828433 - Links on new tab page rely on use of color only

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Marc Seibert (:mseibert)]

Attachment: Screenshot 2023-04-17 at 14.59.32.png

We're adding underlines back to links in the Firefox UI for reasons mentioned in the bug below. Please evaluate if this is applicable to the "New Tabs Page" as well.

One potential change can be found in the "New Tab Page" settings menu. See the attached screenshot.

+++ This bug was initially created as a clone of Bug #1821788 +++

We're setting text-decoration: none on the .text-link classes in common-shared.css and browser-shared.css. common-shared.css is also applying this rule to html|a. activity-stream.css is doing the same thing under their link rules.

By setting this rule we're failing WCAG Success Criterion 1.4.1 Use of Color. The underline is applied to links so they can be easily identified, specially for folks who cannot perceive color differences. See Failure of Success Criterion 1.4.1. Ideally, we should remove that rule from our links.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:amy, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[kpatenio]

Attachment: Bug 1828433 - restore underlines for links in new tab page. r=amy!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/768a364dc7d4
restore underlines for links in new tab page. r=amy

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/768a364dc7d4

Comment 5

[Valentin Bandac [:vbandac], Ecosystem QA]

I have verified this issue using the latest Firefox Beta 115.0b4 (Build Id: 20230611180300) on Windows 10x64, macOS 13.2 and Ubuntu 22.04 LTS. The hyperlinks are underlined by default on macOS and Ubuntu and not underlined when hovered. However, the hyperlinks from NewTab on Windows 10 are underlined only when hovered. @mseibert could you please confirm the expected behavior? Thanks!

Comment 6

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using Firefox Beta 115.0b5 (Build ID: 20230613195413) on Windows 10 x64, macOS 13.2 and Linux Mint 20.2 and I can confirm that the hyperlinks from the new tab are underlined as default.

Comment 7

[Dão Gottwald [:dao]]

(In reply to Valentin Bandac [:vbandac] from comment #5)

I have verified this issue using the latest Firefox Beta 115.0b4 (Build Id: 20230611180300) on Windows 10x64, macOS 13.2 and Ubuntu 22.04 LTS. The hyperlinks are underlined by default on macOS and Ubuntu and not underlined when hovered. However, the hyperlinks from NewTab on Windows 10 are underlined only when hovered. @mseibert could you please confirm the expected behavior? Thanks!

The expected behavior is that links are underlined, full stop. No exception for Windows 10.

Comment 8

[Alice Varro [avarro], Ecosystem QA]

Hello!
Yes, that's correct. Sorry for the missunderstanding, I reverified the issue and I left a comment above. There are no differences between Oses regarding the expected behavior.