Closed Bug 1828433 Opened 2 months ago Closed 26 days ago

Links on new tab page rely on use of color only

Categories

(Firefox :: New Tab Page, defect)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
115 Branch
Project Flags:
Accessibility Severity s2
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: mseibert, Assigned: kpatenio, NeedInfo)

References

Details

(Keywords: access)

Attachments

(2 files)

Screenshot 2023-04-17 at 14.59.32.png
27.79 KB, image/png
Details
Bug 1828433 - restore underlines for links in new tab page. r=amy!
48 bytes, text/x-phabricator-request
Details | Review

We're adding underlines back to links in the Firefox UI for reasons mentioned in the bug below. Please evaluate if this is applicable to the "New Tabs Page" as well.

One potential change can be found in the "New Tab Page" settings menu. See the attached screenshot.

+++ This bug was initially created as a clone of Bug #1821788 +++

We're setting text-decoration: none on the .text-link classes in common-shared.css and browser-shared.css. common-shared.css is also applying this rule to html|a. activity-stream.css is doing the same thing under their link rules.

By setting this rule we're failing WCAG Success Criterion 1.4.1 Use of Color. The underline is applied to links so they can be easily identified, specially for folks who cannot perceive color differences. See Failure of Success Criterion 1.4.1. Ideally, we should remove that rule from our links.

No longer blocks: moz-support-link
Mentor: dao+bmo
No longer depends on: 1828430
See Also: https://mozilla-hub.atlassian.net/browse/FIDEFE-3575 → 1828430
Summary: Link styles relying on use of color only → Links on new tab page rely on use of color only
Whiteboard: [fidefe-reusable-components][access-s2] → [access-s2]
Assignee: nobody → kpatenio
Status: NEW → ASSIGNED

The severity field is not set for this bug.
:amy, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(achurchwell)
Attachment #9330982 - Attachment description: WIP: Bug 1828433 - restore underlines for links in new tab page. r=amy! → Bug 1828433 - restore underlines for links in new tab page. r=amy!
Pushed by kpatenio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/768a364dc7d4
restore underlines for links in new tab page. r=amy

https://hg.mozilla.org/mozilla-central/rev/768a364dc7d4

Status: ASSIGNED → RESOLVED
Closed: 26 days ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
See Also: → 1832855
Accessibility Severity: --- → s2
Whiteboard: [access-s2]
You need to log in before you can comment on or make changes to this bug.