Closed Bug 1828433 Opened 11 months ago Closed 10 months ago

Links on new tab page rely on use of color only

Categories

(Firefox :: New Tab Page, defect)

defect

Tracking

()

VERIFIED FIXED
115 Branch
Accessibility Severity s2
Tracking Status
firefox115 --- verified

People

(Reporter: mseibert, Assigned: kpatenio)

References

Details

(Keywords: access)

Attachments

(2 files)

We're adding underlines back to links in the Firefox UI for reasons mentioned in the bug below. Please evaluate if this is applicable to the "New Tabs Page" as well.

One potential change can be found in the "New Tab Page" settings menu. See the attached screenshot.

+++ This bug was initially created as a clone of Bug #1821788 +++

We're setting text-decoration: none on the .text-link classes in common-shared.css and browser-shared.css. common-shared.css is also applying this rule to html|a. activity-stream.css is doing the same thing under their link rules.

By setting this rule we're failing WCAG Success Criterion 1.4.1 Use of Color. The underline is applied to links so they can be easily identified, specially for folks who cannot perceive color differences. See Failure of Success Criterion 1.4.1. Ideally, we should remove that rule from our links.

No longer blocks: moz-support-link
Mentor: dao+bmo
No longer depends on: 1828430
Summary: Link styles relying on use of color only → Links on new tab page rely on use of color only
Whiteboard: [fidefe-reusable-components][access-s2] → [access-s2]
Assignee: nobody → kpatenio
Status: NEW → ASSIGNED

The severity field is not set for this bug.
:amy, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(achurchwell)
Attachment #9330982 - Attachment description: WIP: Bug 1828433 - restore underlines for links in new tab page. r=amy! → Bug 1828433 - restore underlines for links in new tab page. r=amy!
Pushed by kpatenio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/768a364dc7d4
restore underlines for links in new tab page. r=amy
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
See Also: → 1832855
Accessibility Severity: --- → s2
Whiteboard: [access-s2]

I have verified this issue using the latest Firefox Beta 115.0b4 (Build Id: 20230611180300) on Windows 10x64, macOS 13.2 and Ubuntu 22.04 LTS. The hyperlinks are underlined by default on macOS and Ubuntu and not underlined when hovered. However, the hyperlinks from NewTab on Windows 10 are underlined only when hovered. @mseibert could you please confirm the expected behavior? Thanks!

Flags: needinfo?(mseibert)

I have verified this issue using Firefox Beta 115.0b5 (Build ID: 20230613195413) on Windows 10 x64, macOS 13.2 and Linux Mint 20.2 and I can confirm that the hyperlinks from the new tab are underlined as default.

Status: RESOLVED → VERIFIED

(In reply to Valentin Bandac [:vbandac] from comment #5)

I have verified this issue using the latest Firefox Beta 115.0b4 (Build Id: 20230611180300) on Windows 10x64, macOS 13.2 and Ubuntu 22.04 LTS. The hyperlinks are underlined by default on macOS and Ubuntu and not underlined when hovered. However, the hyperlinks from NewTab on Windows 10 are underlined only when hovered. @mseibert could you please confirm the expected behavior? Thanks!

The expected behavior is that links are underlined, full stop. No exception for Windows 10.

Flags: needinfo?(vbandac)
Flags: needinfo?(mseibert)
Flags: needinfo?(avarro)
Flags: needinfo?(achurchwell)

Hello!
Yes, that's correct. Sorry for the missunderstanding, I reverified the issue and I left a comment above. There are no differences between Oses regarding the expected behavior.

Flags: needinfo?(vbandac)
Flags: needinfo?(avarro)
You need to log in before you can comment on or make changes to this bug.