1828450 - Assertion failure: VideoCaptureAvFoundation::mWatchManager called on "wrong" thread

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Andreas Pehrson [:pehrsons]]

This is a false-positive regression from bug 1817724 where VideoCaptureAvFoundations's WatchManager::Watch trips an assertion in debug builds since it's mOwningThread is a TaskQueue that was just created, therefore not returned by AbstractThread::GetCurrent() (i.e AbstractThread::IsCurrentThreadIn() returns false).

The assertion failure is harmless since the underlying thread is the same with or without the TaskQueue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1817724

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1828450 - Revert fe7300653e99 - Don't buffer frames in VideoCaptureAvFoundation. r?webrtc-reviewers

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1828450 - Revert 9aa28e73aaf8 - In VideoCaptureAvFoundation use MediaEvent to handle frames. r?webrtc-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/622e050b21ce
Revert fe7300653e99 - Don't buffer frames in VideoCaptureAvFoundation. r=webrtc-reviewers,ng
https://hg.mozilla.org/integration/autoland/rev/d96be9abcacd
Revert 9aa28e73aaf8 - In VideoCaptureAvFoundation use MediaEvent to handle frames. r=webrtc-reviewers,ng

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/622e050b21ce
https://hg.mozilla.org/mozilla-central/rev/d96be9abcacd