PiP button tooltip contents are reversed in RTL
Categories
(Toolkit :: Picture-in-Picture, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: itiel_yn8, Assigned: itiel_yn8, NeedInfo)
Details
(Keywords: rtl)
Attachments
(3 files)
Screenshot
More specifically, the shortcut appears before the main text.
|
||
Updated•1 year ago
|
Pushed by itiel_yn8@walla.com: https://hg.mozilla.org/integration/autoland/rev/811606e0c40c Fix PiP button tooltip directionality for RTL r=pip-reviewers,mhowell
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
|
||
Updated•1 year ago
|
|
||
Comment 4•11 months ago
|
||
Reproducible on a 2023-04-17 Nightly build( he-locale) on Windows 10.
Whilst verifying the fix, I noticed that in the latest Nightly all button tooltips are correctly aligned and translated, except for the “Fullscreen”" button(affecting all 3 OS’s).
For Firefox 114.0b7, on macOS only, buttons are not translated and the pause/fullscreen buttons tooltips are still misaligned. Please see this recording for more detail.
Should I open a new separate bug for this ?
Thank you .
The untranslated strings are apparently ones that haven't been approved yet. The one in your screenshot here isn't available for translation at the moment.
As for the misalignment- are you sure that was not the case before this patch? Note that the Fullscreen tooltip should by design look a bit offset so it wouldn't overflow off-PIP.
Description
•