Closed Bug 1828512 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 39577 - Update popover type state in attribute change steps

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 39577 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39577
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Update popover type state in attribute change steps

The attached test shows how it was possible to make an open popover's
attribute be "auto" while the behavior is still "manual" due to our copy
of the attribute type being out of sync with the actual attribute.

This was pointed out here: https://github.com/whatwg/html/issues/9034

Change-Id: I8fa48730fc4f4a340b09dac71c55b7767f317da7

Reviewed-on: https://chromium-review.googlesource.com/4436269
WPT-Export-Revision: 200664e67309434264693d281b6e43eabc4df16c

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Try push failed: decision task Jrf6eOIqTty8PrEfxFy6_w returned error
Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 19 tests ## Status Summary ### Firefox `OK` : 12[GitHub] 13[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] `PASS` : 7[GitHub] 1383[Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 1384[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview] `FAIL` : 438[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview] 439[Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 2614[GitHub] `ERROR` : 1[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 2[GitHub] `NOTRUN` : 20 ### Chrome `OK` : 12 `PASS` : 2603 `FAIL` : 13 `ERROR` : 2 ### Safari `OK` : 10 `PASS` : 8 `FAIL` : 1792 `TIMEOUT`: 4 `ERROR` : 2 `NOTRUN` : 21 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a967bfb4396c667878b893550d0da6749601811) [GitHub PR Head](https://wpt.fyi/results/?sha=1d7c52ea262997bd53a6302a10787990447bcf46&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=1d7c52ea262997bd53a6302a10787990447bcf46&label=pr_base) ## Details ### Firefox-only Failures * [/html/semantics/popovers/popover-attribute-basic.html](https://wpt.live/html/semantics/popovers/popover-attribute-basic.html) [[wpt.fyi](https://wpt.fyi/results/html/semantics/popovers/popover-attribute-basic.html)] * IDL attribute reflection: `FAIL` linked bug:Bug 1808641 (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d2fe9f4302b9 [wpt PR 39577] - Update popover type state in attribute change steps, a=testonly https://hg.mozilla.org/integration/autoland/rev/ed16e4d5b566 [wpt PR 39577] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: