1828591 - subject always initially showing the unencrypted symbol

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Magnus Melin [:mkmelin]]

Even if no encryption whatsoever is configured (new profile), when replying to an email there is now always a flash of the "unencrypted subject" showing.
How long it shows seems to depend a bit on the accounts (less than a sec, but even with a new account maybe 200ms).

Expected results: no unencrypted subject showing

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1828591 - Avoid having unencrypted subject icon flash at start of message compose. r=#thunderbird-reviewers

The call stack is
updateEncryptedSubject()
updateEncryptionDependencies()
checkEncryptionState()
ComposeFieldsReady()

It will get set to hidden/shown later. Just hide it to start off.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b016eed391a1
Avoid having unencrypted subject icon flash at start of message compose. r=kaie

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9360190 [details]
Bug 1828591 - Avoid having unencrypted subject icon flash at start of message compose. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): unclear
User impact if declined: briefly flashing icon in subject field on compose startup
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): very safe

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9360190 [details]
Bug 1828591 - Avoid having unencrypted subject icon flash at start of message compose. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 120.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/256e46f91bc0

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9360190 [details]
Bug 1828591 - Avoid having unencrypted subject icon flash at start of message compose. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 115.4.2:
https://hg.mozilla.org/releases/comm-esr115/rev/2e325aea47e6