1828603 - Optimise MovableCellHasher::match method by checking pointers for equality first

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jon Coppeard (:jonco)]

This is an easy win. We don't need to look up any unique IDs here when passed two equal pointers. This should be the case most of the time.

Doing this improves the weakmap lookup benchmark time from 75.3 ns to 66.9 ns locally, a reduction of 11.2%.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1828603 - Optimize match method to check pointer equality first r?jandem

If the key and lookup pointers are the same we don't need to check the unique
ID.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8edefba923f6
Optimize match method to check pointer equality first r=jandem

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/8edefba923f6