1828643 - DoH UI: Continue this time makes page look broken

Status: RESOLVED FIXED

(Firefox :: Security, task, P1)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

We noticed this is the case for facebook.com
I think the problem might be that the page is using cross-origin-opener-policy which leads to it having an isolated browsing context. Not sure how that applies to nsILoadGroup.defaultLoadFlags - but for some reason they are not propagated properly.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1828643 - Make sure LOAD_TRR_DISABLED_MODE gets passed through defaultLoadFlags when browsing context is replaced r=nika,#necko

When the user clicks continue this time in the DoH fallback warning page
we want to set the defaultLoadFlags to LOAD_TRR_DISABLED_MODE so all of
the pages & subresources in the tab will not use TRR from that point
forward.

Setting it directly on docshell.defaultLoadFlags seems to not have the correct
behaviour when the page is using the Cross-Origin-Opener-Policy header,
as that causes the DocumentChannel to do a cross process redirect and
recreate the browsing context.

Setting the defaultLoadFlags on the browsingContext directly and
adding the field to CanonicalBrowsingContext::ReplacedBy seems to lead to
the expected behaviour.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8915b20f49f
Make sure LOAD_TRR_DISABLED_MODE gets passed through defaultLoadFlags when browsing context is replaced r=necko-reviewers,kershaw

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f8915b20f49f