1828781 - Update PDF.js to new version 42faecf31036232aefcadaceef7a45c71be3f9e1 from 2023-04-18 20:13:19

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement)

Description

[Update Bot]

This update covers 3 commits.. Here are the overall diff statistics, and then the commit information.

---

toolkit/components/pdfjs/content/build/pdf.js | 10 +++---
toolkit/components/pdfjs/content/build/pdf.scripting.js | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.js | 23 +++++++++----
toolkit/components/pdfjs/content/web/viewer-geckoview.js | 26 +++++++++++----
toolkit/components/pdfjs/content/web/viewer.js | 26 +++++++++++----
toolkit/components/pdfjs/moz.yaml | 4 +-
6 files changed, 62 insertions(+), 31 deletions(-)

---

6bfcc9665150a583f2e0e96506f1a946a29de05f by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/6bfcc9665150a583f2e0e96506f1a946a29de05f
Authored: 2023-04-18 20:49:37 +0200
Committed: 2023-04-18 21:12:18 +0200

Disable the "copy all text" feature when enablePermissions is set (PR 16286 follow-up)

When permissions are enabled and the PDF document doesn't have the COPY-flag set, it shouldn't be possible for the user to trigger the "copy all text" feature.

Files Modified:

• web/pdf_viewer.js

---

19ca41896e913587b05a584e4735c54204958c65 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/19ca41896e913587b05a584e4735c54204958c65
Authored: 2023-04-18 16:39:10 +0200
Committed: 2023-04-18 17:00:42 +0200

Correctly clip the text in the text layer (fixes #16316)

Files Added:

• test/pdfs/issue16316.pdf

Files Modified:

• src/core/evaluator.js
• test/pdfs/.gitignore
• test/unit/api_spec.js

---

6ca702d6804097514ecf4f5ded84efa87771182a by linxianxi

https://github.com/mozilla/pdf.js/commit/6ca702d6804097514ecf4f5ded84efa87771182a
Authored: 2023-04-18 17:40:26 +0800
Committed: 2023-04-18 17:40:26 +0800

Compatible with ResizeObserver borderBoxSize in legacy safari

See https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserverEntry/borderBoxSize\#browser_compatibility

Files Modified:

• web/pdf_viewer.js

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=8352555248a79fd67b8c0c64b986cf0d1faa9b31

Comment 2

[Update Bot]

Attachment: Bug 1828781 - Update PDF.js to 42faecf31036232aefcadaceef7a45c71be3f9e1

Comment 3

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Investigation (From Push Health):

• No tests were found for flavor 'plain' and the following manifest filters:
  skip_if, run_if, fail_if, subsuite(name=None), tags(['condprof']), pathprefix(['toolkit/components/pdfjs/test'])

  Make sure the test paths (if any) are spelt correctly and the corresponding
  --flavor and --subsuite are being used. See mach mochitest --help for a
  list of valid flavors.

  • 2 of 2 failed on different tasks
    - test-linux1804-64-qr/opt-mochitest-plain-condprof-1 (bDQQqMb8TNOeYUOPwyCmBQ)
    - test-windows11-64-2009-qr/opt-mochitest-plain-condprof-1 (Q8uyiJD7SCai0AS6xVTMBQ)

Needs Investigation (Other Failed Jobs):

• test-windows11-64-2009-qr/debug-mochitest-devtools-chrome-1
  • 4 of 4 failed on the same (retriggered) task (Ire-Lh-kSM2Iury1M3ICJw, c50FNLOLSciWqFFLZn8rKQ, Cxg908M5RTeefZy7uy7pGA, IDFdm6f7SW-H6gGhqhDxyw)
• test-linux1804-64-qr/debug-mochitest-devtools-chrome-swr-1
  • 4 of 4 failed on the same (retriggered) task (NPCISGE_SoKlaeXL73PqQQ, J7DgNCFjTDCTyVP9dS0iNw, AIz0PcZkRBewqo1y92DZqg, fTKiCIN8RKK-ifU1ls53eQ)
• test-linux1804-64-qr/debug-mochitest-devtools-chrome-spi-nw-1
  • 4 of 4 failed on the same (retriggered) task (QCc1uyaVQmylqGyJy2m8Cw, JXFeHr2fTJqqlSe52F01GQ, PTmaFgePTh63vjUxlqjNXw, UKHfQn_ITYWxErI-7iDNxg)
• test-macosx1015-64-qr/debug-mochitest-devtools-chrome-1
  • 4 of 4 failed on the same (retriggered) task (KjAaiERBQQGaZour7okTWA, TBoFPdnNRyagjL-QsJAF5Q, AQDn_iDyTJm6RwE_zOIfQg, I_e-trs3RMSLDBNroLCTZw)
• test-linux1804-64-qr/debug-mochitest-devtools-chrome-1
  • 4 of 4 failed on the same (retriggered) task (N5_QyAbeTnuAiWnBZXwTgw, UOk-7fKrQguGrrb3XY8Xtw, VluXQTR5ToqOLXKxC5xqMg, Zuw51V_QQrWSe1vBN9m7bQ)
• test-macosx1015-64-qr/debug-mochitest-devtools-chrome-spi-nw-1
  • 4 of 4 failed on the same (retriggered) task (SfAYTSs6TrS4rEayj8kfnA, RK-ijI-ASMyfTrA6dJfCNw, VmZKGfZBR1qYMFe98gE-mg, HNuZ5v77S-izsg_I58gV3w)
• test-windows11-64-2009-qr/debug-mochitest-devtools-chrome-spi-nw-1
  • 4 of 4 failed on the same (retriggered) task (W5myIRuWSSKDw-NVQ3pX3g, WCxOd2_6S2Wn9S7qTo-F8g, a__0f70yQXOMYv_dA3DtZg, GkkOyLFJS96jP6P3JLP2sQ)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor toolkit/components/pdfjs/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/141260e61bc6
Update PDF.js to 42faecf31036232aefcadaceef7a45c71be3f9e1 r=pdfjs-reviewers,calixte

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/141260e61bc6