If the requested Accessible doesn't exist, wait for it to be created
Categories
(Remote Protocol :: Marionette, defect, P3)
Tracking
(firefox115 fixed)
Tracking | Status | |
---|---|---|
firefox115 | --- | fixed |
People
(Reporter: Jamie, Assigned: Jamie)
References
(Regressed 1 open bug)
Details
(Whiteboard: [webdriver:m7][webdriver:external][webdriver:relnote])
Attachments
(1 file, 2 obsolete files)
The tests in testing/web-platform/tests/wai-aria/role/roles.html pass/fail intermittently. My guess is that they fail because the nodes are dynamically added to the tree, but the a11y engine doesn't add them to the a11y tree until the next refresh driver tick and WebDriver tries to query them before that.
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
I'm working on this regardless, but it's worth noting that the fix for this needs to happen in Marionette, not in the a11y module or the a11y tests.
Comment 2•2 years ago
|
||
I would suggest to file a specific bug for Marionette which better explains what needs to be changed / added so that it's also clear for the release notes. Thanks!
Assignee | ||
Comment 3•2 years ago
|
||
Some tests dynamically add elements to the DOM.
Since accessibility updates occur in refresh driver ticks, the Accessible often wasn't created yet when WebDriver requested it, causing intermittent WPT failures.
See the code comments for an explanation of how this works.
Assignee | ||
Comment 4•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Comment 6•2 years ago
|
||
Backed out for causing multiple failures.
- Pushes with failures - wpt
- Failure Log
- Failure line: TEST-UNEXPECTED-PASS | /html-aam/roles.html | el-address - expected FAIL
- Pushes with failures - mochitests
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | accessible/tests/browser/role/browser_computedARIARole.js | computedARIARole for htmlTbody is correct - Got "group", expected "rowgroup"
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Comment 8•2 years ago
|
||
Backed out for wpt failures on roles.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/97bea5458631b195b0ed36337f9fc172f35a983a
Log link: https://treeherder.mozilla.org/logviewer?job_id=413938354&repo=autoland&lineNumber=2731
Comment 9•2 years ago
|
||
Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/97bea5458631
Updated•2 years ago
|
Comment 10•2 years ago
|
||
Comment 11•2 years ago
•
|
||
Backed out for causing wpt failures in roles.html
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | /wai-aria/role/roles.html | role: timer - assert_equals: <div role="timer" id="role_timer">x</div> expected (string) "timer" but got (object) null
Comment 12•2 years ago
|
||
Comment 13•2 years ago
|
||
Backed out for causing high frequency failures on /html-aam/roles.html
- backout: https://hg.mozilla.org/integration/autoland/rev/7a8c09a538e06264a1463729ca57dc07086de7a2
- push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=GoG0mvykRGmgRHa7d4pZyw.0&revision=f3f51a672d706005d6de5af2d770f84a2f4b1765
- failure log: https://treeherder.mozilla.org/logviewer?job_id=415361447&repo=autoland&lineNumber=9520
[task 2023-05-11T13:50:33.758Z] 13:50:33 INFO - TEST-FAIL | /html-aam/roles.html | el-small - assert_equals: <small data-testname="el-small" data-expectedrole="generic" class="ex" id="generic15">x</small> expected (string) "generic" but got (object) null
[task 2023-05-11T13:50:33.758Z] 13:50:33 INFO - verifyRolesBySelector/<@http://web-platform.test:8000/wai-aria/scripts/aria-utils.js:55:22
[task 2023-05-11T13:50:33.758Z] 13:50:33 INFO - TEST-UNEXPECTED-TIMEOUT | /html-aam/roles.html | el-span - Test timed out
[task 2023-05-11T13:50:33.758Z] 13:50:33 INFO - TEST-INFO | expected FAIL
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO -
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO - TEST-UNEXPECTED-NOTRUN | /html-aam/roles.html | el-strong - expected FAIL
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO - TEST-INFO | expected FAIL
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO -
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO - TEST-UNEXPECTED-NOTRUN | /html-aam/roles.html | el-sub - expected PASS
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO -
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO - TEST-UNEXPECTED-NOTRUN | /html-aam/roles.html | el-sup - expected PASS
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO -
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO - TEST-UNEXPECTED-NOTRUN | /html-aam/roles.html | el-time - expected FAIL
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO - TEST-INFO | expected FAIL
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO -
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO - TEST-UNEXPECTED-NOTRUN | /html-aam/roles.html | el-textarea - expected PASS
[task 2023-05-11T13:50:33.759Z] 13:50:33 INFO -
[task 2023-05-11T13:50:33.760Z] 13:50:33 INFO - TEST-UNEXPECTED-NOTRUN | /html-aam/roles.html | el-u - expected FAIL
[task 2023-05-11T13:50:33.760Z] 13:50:33 INFO - TEST-INFO | expected FAIL
[task 2023-05-11T13:50:33.760Z] 13:50:33 INFO -
[task 2023-05-11T13:50:33.761Z] 13:50:33 INFO - TEST-UNEXPECTED-NOTRUN | /html-aam/roles.html | el-ul - expected PASS
[task 2023-05-11T13:50:33.763Z] 13:50:33 INFO - TEST-UNEXPECTED-TIMEOUT | /html-aam/roles.html | expected OK
[task 2023-05-11T13:50:33.764Z] 13:50:33 INFO - TEST-INFO took 10527ms
Updated•2 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 14•2 years ago
|
||
Some tests dynamically add elements to the DOM.
Since accessibility updates occur in refresh driver ticks, the Accessible often wasn't created yet when WebDriver requested it, causing intermittent WPT failures.
Now, we force refresh driver ticks to give accessibility a chance to update.
Comment 15•2 years ago
|
||
Assignee | ||
Updated•2 years ago
|
Comment 16•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•