1829056 - accessibility bugs with editboxes on Firefox for android

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[techexplorers2020]

User Agent: Mozilla/5.0 (Android 12; Mobile; rv:109.0) Gecko/111.0 Firefox/111.0
Firefox for Android

Steps to reproduce:

Step 1, turn on talk back. Step 2, open Firefox and find an edit box. Step 3, input text. while at it, try deleting. Step 4, try to navigate by words, characters, lines.

Actual results:

When deleting or typing text it won't get announced.
Also when trying to navigate the text, it won't also get announced.

Expected results:

It should announce the text while navigating and also while typing or deleting

Comment 1

[James Teh [:Jamie]]

Eitan, any ideas?

Comment 2

[Eitan Isaacson [:eeejay]]

Navigating by character word or line works for me and I do hear the subtring representing the range the caret moved.

I see two issues though: deleting text does not get announced and inserting text does not get announced.

Comment 3

[Eitan Isaacson [:eeejay]]

Ah. I see now that with an external keyboard moving the caret doesn't speak the selection changes. I guess when you use gestures you get spoken text navigation via talkback.

Comment 4

[Eitan Isaacson [:eeejay]]

These are two separate issues though. Looks like we never sent fromIndex in the TYPE_VIEW_TEXT_CHANGED event. And in the TYPE_VIEW_TEXT_SELECTION_CHANGED we don't send the text contents of the accessible where the text selection happened.

I want to believe that this used to work in earlier versions of TalkBack without those fields, but I can't prove that!

Comment 5

[techexplorers2020]

(In reply to Eitan Isaacson [:eeejay] from comment #2)

Navigating by character word or line works for me and I do hear the subtring representing the range the caret moved.

I see two issues though: deleting text does not get announced and inserting text does not get announced.

hi.
forgot to mention something on the bug the text navigation problem only effect the address bar.
again, sorry for that i forgot to provide that.
the text input and deletion but is present everywhere though.
also, the one other thing i noticed is that you can't check if the password field is empty or not as it won't show them.
i am not saying the password should be visible. but it should show the hidden char "*".
check chrome to see how it should be.
thanks.
i hope these will be fixed soon.

Comment 6

[techexplorers2020]

(In reply to Eitan Isaacson [:eeejay] from comment #4)

I want to believe that this used to work in earlier versions of TalkBack without those fields, but I can't prove that!
well i started using firefox from the mid of 2021 and the bug is there even then.
just didn't got time to report it.

Comment 7

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1829056 - P1: Include text in TYPE_VIEW_TEXT_SELECTION_CHANGED events. r?Jamie

Depends on D177807

Comment 8

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1829056 - P2: Include fromIndex in TYPE_VIEW_TEXT_CHANGED events. r?Jamie

Depends on D177808

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a96af3a6279
P1: Include text in TYPE_VIEW_TEXT_SELECTION_CHANGED events. r=Jamie,geckoview-reviewers,m_kato
https://hg.mozilla.org/integration/autoland/rev/4cc3d74ec36b
P2: Include fromIndex in TYPE_VIEW_TEXT_CHANGED events. r=Jamie,geckoview-reviewers,m_kato

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6a96af3a6279
https://hg.mozilla.org/mozilla-central/rev/4cc3d74ec36b