Closed Bug 1829268 Opened 2 years ago Closed 1 year ago

Perma Win MinGW [tier 2] rlbox.wasm.c:12:10: fatal error: 'alloca.h' file not found

Categories

(Core :: Security: RLBox, defect, P5)

defect

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox112 --- unaffected
firefox113 --- unaffected
firefox114 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: shravanrn)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered])

Attachments

(1 file)

Filed by: ctuns [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=413241310&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Ky9vhNjBSPq_5dFDhjJuNg/runs/0/artifacts/public/logs/live_backing.log


[task 2023-04-21T01:45:42.826Z] 01:45:42     INFO -  accessible/interfaces/ia2/IA2Marshal.dll.res
[task 2023-04-21T01:45:42.827Z] 01:45:42     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/config/create_res.py -DDEBUG=1 -DREGISTER_PROXY_DLL -DMOZ_HAS_MOZGLUE -I/builds/worker/checkouts/gecko/accessible/interfaces/ia2 -I/builds/worker/workspace/obj-build/accessible/interfaces/ia2  -I/builds/worker/workspace/obj-build/dist/include  -o IA2Marshal.dll.res IA2Marshal.dll.rc
[task 2023-04-21T01:45:42.827Z] 01:45:42     INFO -  Executing: /builds/worker/fetches/clang/bin/i686-w64-mingw32-windres -O coff -D DEBUG=1 -D REGISTER_PROXY_DLL -D MOZ_HAS_MOZGLUE --include-dir /builds/worker/checkouts/gecko/accessible/interfaces/ia2 --include-dir /builds/worker/workspace/obj-build/accessible/interfaces/ia2 --include-dir /builds/worker/workspace/obj-build/dist/include -o IA2Marshal.dll.res IA2Marshal.dll.rc
[task 2023-04-21T01:45:42.828Z] 01:45:42     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/accessible/interfaces/ia2'
[task 2023-04-21T01:45:42.828Z] 01:45:42     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/accessible/interfaces/ia2'
[task 2023-04-21T01:45:42.828Z] 01:45:42     INFO -  accessible/interfaces/ia2/IA2Marshal.dll
[task 2023-04-21T01:45:42.829Z] 01:45:42     INFO -  rm -f IA2Marshal.dll
[task 2023-04-21T01:45:42.829Z] 01:45:42     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/accessible/interfaces/ia2'
[task 2023-04-21T01:45:42.894Z] 01:45:42     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/security/rlbox'
[task 2023-04-21T01:45:42.895Z] 01:45:42     INFO -  security/rlbox/rlbox.wasm.o
[task 2023-04-21T01:45:42.899Z] 01:45:42     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/i686-w64-mingw32-clang -Qunused-arguments -std=gnu99 -o rlbox.wasm.o -c  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DWASM_RT_USE_MMAP=1 -DWASM_RT_SKIP_SIGNAL_RECOVERY=1 -DWASM_RT_TRAP_HANDLER=moz_wasm2c_trap_handler -DWASM_RT_USE_STACK_DEPTH_COUNT=0 -DWASM_RT_GROW_FAILED_HANDLER=moz_wasm2c_memgrow_failed -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/security/rlbox -I/builds/worker/workspace/obj-build/security/rlbox -I/builds/worker/checkouts/gecko/third_party/wasm2c/wasm2c -I/builds/worker/checkouts/gecko/extensions/spellcheck/hunspell/glue -I/builds/worker/checkouts/gecko/extensions/spellcheck/hunspell/src -I/builds/worker/checkouts/gecko/gfx/graphite2/src -I/builds/worker/checkouts/gecko/media/libogg -I/builds/worker/checkouts/gecko/parser/expat/lib -I/builds/worker/checkouts/gecko/modules/woff2/include -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -include /builds/worker/workspace/obj-build/mozilla-config.h -DMOZILLA_CLIENT -fcrash-diagnostics-dir=/builds/worker/artifacts -D_HAS_EXCEPTIONS=0 -mstackrealign -ffunction-sections -fdata-sections -fno-math-errno -pipe -g -gcodeview -O2 -fno-omit-frame-pointer -funwind-tables -Wall -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wstring-conversion -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-unknown-pragmas -Wno-unused-function -Wno-conversion-null -Wno-switch -Wno-enum-compare -Werror=implicit-function-declaration -Wno-psabi -Wthread-safety -Wno-unknown-warning-option -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/rlbox.wasm.o.pp   rlbox.wasm.c
[task 2023-04-21T01:45:42.899Z] 01:45:42     INFO -  rlbox.wasm.c:12:10: fatal error: 'alloca.h' file not found
[task 2023-04-21T01:45:42.900Z] 01:45:42     INFO -  #include <alloca.h>
[task 2023-04-21T01:45:42.900Z] 01:45:42     INFO -           ^~~~~~~~~~
[task 2023-04-21T01:45:42.900Z] 01:45:42     INFO -  1 error generated.
[task 2023-04-21T01:45:42.900Z] 01:45:42    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:585: rlbox.wasm.o] Error 1
[task 2023-04-21T01:45:42.901Z] 01:45:42     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/security/rlbox'
[task 2023-04-21T01:45:42.901Z] 01:45:42     INFO -  gmake[4]: Target 'target-objects' not remade because of errors.
[task 2023-04-21T01:45:42.901Z] 01:45:42    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: security/rlbox/target-objects] Error 2
[task 2023-04-21T01:45:42.923Z] 01:45:42     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/accessible/interfaces/ia2'
[task 2023-04-21T01:45:42.925Z] 01:45:42     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/i686-w64-mingw32-clang -Qunused-arguments -std=gnu99 -shared -Wl,--out-implib -Wl,libIA2Marshal.a -Wl,-pdb,IA2Marshal.pdb -o IA2Marshal.dll Accessible2_2_i.o Accessible2_2_p.o Accessible2_3_i.o Accessible2_3_p.o Accessible2_i.o Accessible2_p.o AccessibleAction_i.o AccessibleAction_p.o AccessibleApplication_i.o AccessibleApplication_p.o AccessibleComponent_i.o AccessibleComponent_p.o AccessibleDocument_i.o AccessibleDocument_p.o AccessibleEditableText_i.o AccessibleEditableText_p.o AccessibleHyperlink_i.o AccessibleHyperlink_p.o AccessibleHypertext2_i.o AccessibleHypertext2_p.o AccessibleHypertext_i.o AccessibleHypertext_p.o AccessibleImage_i.o AccessibleImage_p.o AccessibleRelation_i.o AccessibleRelation_p.o AccessibleTable2_i.o AccessibleTable2_p.o AccessibleTableCell_i.o AccessibleTableCell_p.o AccessibleTable_i.o AccessibleTable_p.o AccessibleText2_i.o AccessibleText2_p.o AccessibleText_i.o AccessibleText_p.o AccessibleValue_i.o AccessibleValue_p.o dlldata.o IA2Marshal.dll.res  -Wl,--no-insert-timestamp -Wl,--large-address-aware -Wl,--icf=safe -lssp -fstack-protector-strong -Wl,--dynamicbase ../../../../../checkouts/gecko/accessible/interfaces/ia2/IA2Marshal.def   ../../../mozglue/build/libmozglue.a   -luuid -lkernel32 -lrpcrt4 -lole32 -loleaut32
[task 2023-04-21T01:45:42.925Z] 01:45:42     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/accessible/interfaces/ia2'
[task 2023-04-21T01:45:42.929Z] 01:45:42     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/accessible/interfaces/msaa'
[task 2023-04-21T01:45:42.930Z] 01:45:42     INFO -  accessible/interfaces/msaa/AccessibleMarshal.dll.res
[task 2023-04-21T01:45:42.931Z] 01:45:42     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/config/create_res.py -DDEBUG=1 -DREGISTER_PROXY_DLL -DPROXY_CLSID=IID_ISimpleDOMNode -DMOZ_HAS_MOZGLUE -I/builds/worker/checkouts/gecko/accessible/interfaces/msaa -I/builds/worker/workspace/obj-build/accessible/interfaces/msaa  -I/builds/worker/workspace/obj-build/dist/include  -o AccessibleMarshal.dll.res AccessibleMarshal.dll.rc
[task 2023-04-21T01:45:42.932Z] 01:45:42     INFO -  Executing: /builds/worker/fetches/clang/bin/i686-w64-mingw32-windres -O coff -D DEBUG=1 -D REGISTER_PROXY_DLL -D PROXY_CLSID=IID_ISimpleDOMNode -D MOZ_HAS_MOZGLUE --include-dir /builds/worker/checkouts/gecko/accessible/interfaces/msaa --include-dir /builds/worker/workspace/obj-build/accessible/interfaces/msaa --include-dir /builds/worker/workspace/obj-build/dist/include -o AccessibleMarshal.dll.res AccessibleMarshal.dll.rc
[task 2023-04-21T01:45:42.932Z] 01:45:42     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/accessible/interfaces/msaa'
[task 2023-04-21T01:45:42.941Z] 01:45:42     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/security'
[task 2023-04-21T01:45:42.943Z] 01:45:42     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/i686-w64-mingw32-clang -Qunused-arguments -std=gnu99 -shared -Wl,--out-implib -Wl,libnss3.a -Wl,-pdb,nss3.pdb -o nss3.dll @/builds/worker/workspace/obj-build/security/nss3_dll.list nss3.dll.res  -Wl,--no-insert-timestamp -Wl,--large-address-aware -Wl,--icf=safe -lssp -fstack-protector-strong -Wl,--dynamicbase -Wl,-Xlink=-DELAYLOAD:winmm.dll   ../mozglue/build/libmozglue.a nss3.dll.def  -ladvapi32 -lwsock32 -lws2_32 -lmswsock -lwinmm -ldelayimp
[task 2023-04-21T01:45:42.944Z] 01:45:42     INFO -  ld.lld: warning: nss/lib/certdb/certdb_certdb/alg1485.o: locally defined symbol imported: _PR_Assert (defined in ../config/external/nspr/pr/Unified_c_external_nspr_pr0.o) [LNK4217]
[task 2023-04-21T01:45:42.944Z] 01:45:42     INFO -  ld.lld: warning: nss/lib/certdb/certdb_certdb/alg1485.o: locally defined symbol imported: _PR_smprintf (defined in ../config/external/nspr/pr/Unified_c_external_nspr_pr0.o) [LNK4217]
[task 2023-04-21T01:45:42.944Z] 01:45:42     INFO -  ld.lld: warning: nss/lib/certdb/certdb_certdb/alg1485.o: locally defined symbol imported: _PR_smprintf_free (defined in ../config/external/nspr/pr/Unified_c_external_nspr_pr0.o) [LNK4217]
[task 2023-04-21T01:45:42.946Z] 01:45:42     INFO -  ld.lld: warning: nss/lib/certdb/certdb_certdb/certdb.o: locally defined symbol imported: _PR_Assert (defined in ../config/external/nspr/pr/Unified_c_external_nspr_pr0.o) [LNK4217]

:shravanrn, since you are the author of the regressor, bug 1827704, could you take a look?

For more information, please visit auto_nag documentation.

Flags: needinfo?(shravanrn)
Component: Security: PSM → Security: RLBox

The following patch fixes it, but I'm not sure it's upstreamable, as it essentially assumes the compiler supports __has_include.

--- a/third_party/wasm2c/src/prebuilt/wasm2c_source_includes.cc
+++ b/third_party/wasm2c/src/prebuilt/wasm2c_source_includes.cc
@@ -16,7 +16,7 @@ R"w2c_template(#include <malloc.h>
 )w2c_template"
 R"w2c_template(#define alloca _alloca
 )w2c_template"
-R"w2c_template(#else
+R"w2c_template(#elif __has_include(<alloca.h>)
 )w2c_template"
 R"w2c_template(#include <alloca.h>
 )w2c_template"

Set release status flags based on info from the regressing bug 1827704

I'll look into a fix that is upstreamable now.

Flags: needinfo?(shravanrn)
Assignee: nobody → shravanrn
Whiteboard: [retriggered]
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/4f0bd2f63bdb Update wasm2c compiler used with RLBox to support MinGW r=glandium
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: