1829273 - release1 indexing failure 2023-04-20

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Reported in matrix, https://matrix.to/#/!CkMpYfqNfmtTHVKwde:mozilla.org/$B7HXxAlbODAOVDEEi_TaJj1MYyP8gpUDMykkQKffpoI?via=mozilla.org&via=t2bot.io

I did some investigation and discovered that this line was crashing:

File gtests/common/testvectors/hmac-sha256-vectors.h
thread 'main' panicked at 'removal index (is 0) should be < len (is 0)', src/file_format/crossref_converter.rs:30:60
stack backtrace:
   0: rust_begin_unwind
             at /rustc/39c6804b92aa202369e402525cee329556bc1db0/library/std/src/panicking.rs:578:5
   1: core::panicking::panic_fmt
             at /rustc/39c6804b92aa202369e402525cee329556bc1db0/library/core/src/panicking.rs:67:14
   2: alloc::vec::Vec<T,A>::remove::assert_failed
             at /rustc/39c6804b92aa202369e402525cee329556bc1db0/library/alloc/src/vec/mod.rs:1501:13
   3: alloc::vec::Vec<T,A>::remove
             at /rustc/39c6804b92aa202369e402525cee329556bc1db0/library/alloc/src/vec/mod.rs:1506:13
   4: tools::file_format::crossref_converter::convert_crossref_value_to_sym_info_rep::{{closure}}
             at ./mozsearch/tools/src/file_format/crossref_converter.rs:30:54
   5: tools::file_format::crossref_converter::convert_crossref_value_to_sym_info_rep
             at ./mozsearch/tools/src/file_format/crossref_converter.rs:59:13
   6: crossref::main::{{closure}}
             at ./mozsearch/tools/src/bin/crossref.rs:487:28
   7: tokio::park::thread::CachedParkThread::block_on::{{closure}}
             at ./.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.15.0/src/park/thread.rs:263:54
   8: tokio::coop::with_budget::{{closure}}
             at ./.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.15.0/src/coop.rs:102:9
   9: std::thread::local::LocalKey<T>::try_with
             at /rustc/39c6804b92aa202369e402525cee329556bc1db0/library/std/src/thread/local.rs:252:16
  10: std::thread::local::LocalKey<T>::with
             at /rustc/39c6804b92aa202369e402525cee329556bc1db0/library/std/src/thread/local.rs:228:9
  11: tokio::coop::with_budget
             at ./.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.15.0/src/coop.rs:95:5
  12: tokio::coop::budget
             at ./.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.15.0/src/coop.rs:72:5
  13: tokio::park::thread::CachedParkThread::block_on
             at ./.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.15.0/src/park/thread.rs:263:31
  14: tokio::runtime::enter::Enter::block_on
             at ./.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.15.0/src/runtime/enter.rs:151:13
  15: tokio::runtime::thread_pool::ThreadPool::block_on
             at ./.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.15.0/src/runtime/thread_pool/mod.rs:77:9
  16: tokio::runtime::Runtime::block_on
             at ./.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.15.0/src/runtime/mod.rs:463:43
  17: crossref::main
             at ./mozsearch/tools/src/bin/crossref.rs:534:5
  18: core::ops::function::FnOnce::call_once
             at /rustc/39c6804b92aa202369e402525cee329556bc1db0/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

That was causing the nss identifiers file to not get generated, causing the router.py script to fail on startup with this:

Traceback (most recent call last):
  File "/home/ubuntu/mozsearch/router/router.py", line 857, in <module>
    identifiers.load(config)
  File "/home/ubuntu/mozsearch/router/identifiers.py", line 19, in load
    with open(os.path.join(index_path, 'identifiers')) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/ubuntu/index/nss/identifiers'

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: GitHub Pull Request

This may not be the best fix but should be good enough to stop the immediate problem.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Note that the release3 indexer was failing on the same line on comm-esr60:

File chat/chat-prefs.js
thread 'main' panicked at 'removal index (is 0) should be < len (is 0)', src/file_format/crossref_converter.rs:30:60
stack backtrace:

Comment 3

[Kartikaya Gupta (email:[e-mail])]

The patch seems to have resolved this issue, marking as fixed.