1829308 - The subtitles panel should close if the subtitle settings button becomes inactive

Status: NEW

(Toolkit :: Picture-in-Picture, enhancement)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user watches a video with subtitles in PiP, he opens the subtitle settings panel and then clicks another video that does not have subtitles (or an ad is displayed), he will notice that the subtitle settings button becomes inactive, but the panel remains open. It should close automatically in this situation.

Found in

• Beta v113.0b5

Affected versions

• Beta v113.0b5

Tested platforms

• Affected platforms: Ubuntu 22, Windows 10, MacOS 11
• Unaffected platforms:

Steps to reproduce

1. Play a Youtube video with subs.
2. Launch the PiP.
3. Open the PiP's Subtitles panel.
4. Click on another video thumbnail from the page.
   (Supposably, it does not have available subs)

Expected result

• The new video plays in the PiP, the subtitles button becomes inactive and the subtitles panel closes automatically.

Actual result

• The new video plays in the PiP, the subtitles button becomes inactive and the subtitles panel remains open incorrectly.

Regression range

• This is not a recent regression.

Additional notes

• additional_note1