Closed
Bug 1829412
Opened 3 years ago
Closed 2 years ago
Remove enrollmentPromise usage from ExperimentFakes consumers
Categories
(Firefox :: Nimbus Desktop Client, task, P4)
Firefox
Nimbus Desktop Client
Tracking
()
RESOLVED
FIXED
128 Branch
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: beth, Assigned: beth)
References
Details
Attachments
(2 files)
Bug 1773583 is making enrollment stub sync, so we can remove all the await enrollmentPromise code
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → brennie
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•2 years ago
|
||
The enrollmentHelper was much more complicated than it needed to be. The
internal asynchrony that required awaiting an additional promise was fixed in
bug 1773583.
The returned cleanup function is no longer async, so unnecessary awaits have
been removed. This also applies to enrollWithFeatureConfig, as it is a wrapper
around enrollmentHelper.
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13f07f4d53ee
Use enrollWithFeatureConfig in quicksuggest tests r=daisuke
https://hg.mozilla.org/integration/autoland/rev/c9e0808f14ca
Simplify NimbusTestUtils.enrollmentHelper r=chumphreys,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,omc-reviewers,home-newtab-reviewers,thecount,issammani,aminomancer,mconley
https://hg.mozilla.org/mozilla-central/rev/13f07f4d53ee
https://hg.mozilla.org/mozilla-central/rev/c9e0808f14ca
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox128:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•