1829456 - Logins Sync engine should roundtrip data it doesn't know about

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Sammy Khamis [:skhamis]]

+++ This bug was initially created as a clone of Bug #1825905 +++

Based on the ADR: https://github.com/mozilla/application-services/pull/5434

(summary from ADR above)

Sync exists on all platforms (Desktop, Android, iOS), all channels (Nightly, Beta, Release, ESR) and is heavily used across all Firefox features.
Whenever there are feature changes or requests that potentially involve schema changes, there are not a lot of good options to ensure sync doesn’t break for any specific client.
Since sync data is synced from all channels, we need to make sure each client can handle the new data and that all channels can support the new schema.
Issues like credit card failing on android and desktop release channels due to schema change on desktop Nightly
are examples of such cases we can run into.
This document describes our decision on how we will support payload evolution over time.

This bug is to implement roundtripping for the logins engine on desktop.

Android and iOS implementation done here: https://github.com/mozilla/application-services/pull/5413

Comment 1

[Sammy Khamis [:skhamis]]

Attachment: Bug 1829456: logins engine round trips data it doesn't know about r?markh,sgalich

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca712de42eca
logins engine round trips data it doesn't know about r=markh,credential-management-reviewers,sync-reviewers,sgalich

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for causing xpcshell failures on test_password_engine.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=ca712de42ecad924eb891a829892af669e4d7c96&selectedTaskRun=LZ1gQh-XQGKej2dPzpJ-JA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=416836485&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/10d84869e3d4898cf0942ed4f20b96ff08f2e4ad

Comment 4

[Sammy Khamis [:skhamis]]

Attachment: Bug 1829456: logins engine round trips data it doesn't know about r?markh,sgalich

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66eb04bb2c0b
logins engine round trips data it doesn't know about r=sgalich

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/66eb04bb2c0b