1829539 - Perma /html/semantics/scripting-1/the-script-element/module/dynamic-import/alpha/base-url-worker-importScripts.html | Relative URL-like from same-origin importScripts() when Gecko 114 merges to Beta on 2023-05-08

Status: VERIFIED FIXED

(Testing :: web-platform-tests, defect)

Description

[Noemi Erli[:noemi_erli]]

[Tracking Requested - why for this release]:

Central-as-beta simulation:
How to run these simulations:
Failure log

[task 2023-04-23T11:38:45.445Z] 11:38:45     INFO - TEST-START | /html/semantics/scripting-1/the-script-element/module/dynamic-import/alpha/base-url-worker-importScripts.html
[task 2023-04-23T11:38:45.450Z] 11:38:45     INFO - Closing window 34359c6c-b7e9-48dc-b5cc-a33b147dc0b0
[task 2023-04-23T11:38:45.629Z] 11:38:45     INFO - PID 8786 | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpnqy48jyr/runtests_leaks_1185_tab_pid25587.log
[task 2023-04-23T11:38:45.630Z] 11:38:45     INFO - PID 8786 | [25587, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp:345
[task 2023-04-23T11:38:45.636Z] 11:38:45     INFO - PID 8786 | [Child 25587, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:475
[task 2023-04-23T11:38:45.661Z] 11:38:45     INFO - PID 8786 | [Child 25587, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:655
[task 2023-04-23T11:38:45.668Z] 11:38:45     INFO - PID 8786 | [Child 25587, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:475
[task 2023-04-23T11:38:45.670Z] 11:38:45     INFO - PID 8786 | [Child 25587, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:475
[task 2023-04-23T11:38:45.694Z] 11:38:45     INFO - PID 8786 | [Child 25587, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:475
[task 2023-04-23T11:38:45.767Z] 11:38:45     INFO - PID 8786 | [Child 25477, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:475
[task 2023-04-23T11:38:46.201Z] 11:38:46     INFO - 
[task 2023-04-23T11:38:46.201Z] 11:38:46     INFO - TEST-UNEXPECTED-FAIL | /html/semantics/scripting-1/the-script-element/module/dynamic-import/alpha/base-url-worker-importScripts.html | Relative URL-like from same-origin importScripts() - promise_test: Unhandled rejection with value: object "Error: Dynamic module import is disabled or not supported in this context"
[task 2023-04-23T11:38:46.201Z] 11:38:46     INFO - 
[task 2023-04-23T11:38:46.201Z] 11:38:46     INFO - TEST-UNEXPECTED-FAIL | /html/semantics/scripting-1/the-script-element/module/dynamic-import/alpha/base-url-worker-importScripts.html | Absolute URL-like from same-origin importScripts() - promise_test: Unhandled rejection with value: object "Error: Dynamic module import is disabled or not supported in this context"
[task 2023-04-23T11:38:46.203Z] 11:38:46     INFO - 

Artur Iunusov this seems to be a regression from Bug 1646034, could you please take a look?
Thanks,

Comment 1

[Artur Iunusov]

At the first glance, I see that the dynamic import is disabled for that test (for some reason).
"Error: Dynamic module import is disabled or not supported in this context"

Previously this test was marked as expected to fail

Looking

Comment 5

[Artur Iunusov]

Attachment: Bug 1829539 - base-url-worker-importScripts.html expected to PASS on Nightly only (due to disabled dynamic import on release and beta), r=smaug

Comment 6

[Norisz Fay [:noriszfay]]

Patch seems to be working as seen in today's central as beta sim

Comment 7

[Artur Iunusov]

Comment on attachment 9330015 [details]
Bug 1829539 - base-url-worker-importScripts.html expected to PASS on Nightly only (due to disabled dynamic import on release and beta), r=smaug

Beta/Release Uplift Approval Request

• User impact if declined: WPT test will be broken. If you include 1646034 and reject this uplift
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1646034
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7b622a1d2bc
base-url-worker-importScripts.html expected to PASS on Nightly only (due to disabled dynamic import on release and beta), r=smaug

Comment 9

[Narcis Beleuzu [:NarcisB]]

We have imported the patch and now it`s failing with "TEST-UNEXPECTED-PASS | /html/semantics/scripting-1/the-script-element/module/dynamic-import/alpha/base-url-worker-importScripts.html | Relative URL-like from cross-origin importScripts() - expected FAIL"
Fails are on Linux, Windows and OSX.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

That was my fault, sorry.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9330015 [details]
Bug 1829539 - base-url-worker-importScripts.html expected to PASS on Nightly only (due to disabled dynamic import on release and beta), r=smaug

test-only changes don't need approval for uplift

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f91b684a36f9

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Sorry, I totally misread comment 9. We're seeing those same failures on Beta now too with this patch uplifted.

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d7b622a1d2bc

Comment 15

[Cosmin Sabou [:CosminS]]

Attachment: Bug 1829539 - Remove unnecessary subtest annotation for release or beta because it's passing. r=smaug,aiunusov

Comment 16

[Sandor Molnar[:smolnar]]

the latest patch seems to be working in today's beta sim

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/281ad380a92d
Remove unnecessary subtest annotation for release or beta because it's passing. r=smaug

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e82134aef685

Comment 19

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/281ad380a92d

Comment 20

[Cosmin Sabou [:CosminS]]

Fix verified: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=a9a490f04fdf979427eec40d00319448e00561f2&test_paths=%2Fhtml%2Fsemantics%2Fscripting-1