1829582 - [wpt-sync] Sync PR 39658 - [css-flex] Disable fixed-table's infinite size for intrinsic flex sizing

Status: RESOLVED FIXED

(Core :: Layout: Tables, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39658 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39658
Details from upstream follow.

David Grogan <[e-mail]> wrote:

[css-flex] Disable fixed-table's infinite size for intrinsic flex sizing

A fixed-table's intrinsic max-content is ~infinite when it has a
%-width. That's been around for a while and ships in all browsers.

But it is problematic for the new flex intrinsic sizing algorithm
because now the infinity percolates up to the flex container's
min-content size[1]. We obviously don't want a min-content size of
infinity and gmail relies on the old behavior.

So this is a hacky patch that makes fixed-tables max-content size be the
same as auto-tables when an ancestor flex table is calculating its
intrinsic sizes. It will probably be web compatible, but unsure.

This affects both the min and max intrinsic size of the flex container.

[1] New flex min-content algorithm accounts for item's flex base sizes.
A %-width fixed-table's flex base size is its max-content size, which,
as mentioned above, is ~infinity.

Change-Id: I7010fa73df8e88a4812b23780e5d58a3f63da730
Bug: 240765

Reviewed-on: https://chromium-review.googlesource.com/4420422
WPT-Export-Revision: 83297b3034d77972a9a4c00b9cc46f0d59416518

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c819819f19384fad43ee49eb12dbf55a0f9e024

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Try push failed: decision task RxYcI2T7RE27cjaOTk83XA returned error

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3628e15960f0aa83e5d1508f9792a6fb78b2f8a

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Try push failed: decision task CZUhLuBHTPqlWPR4p-Ioyg returned error

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e70d2e71b539cbc2a32ec91984f67987d70b70e

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
PASS: 8

Chrome

OK : 1
PASS: 8

Safari

OK : 1
PASS: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4d8e34d1139
[wpt PR 39658] - [css-flex] Disable fixed-table's infinite size for intrinsic flex sizing, a=testonly

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d4d8e34d1139