1829618 - Enable Prettier on json files

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P2)

Description

[Mark Banner (:standard8)]

As part of the forthcoming Prettier upgrades, we also want to enable Prettier for JSON files. This forms part of bug 1563927 where we can later think about enabling ESLint for JSON as well.

I think we might as well enable Prettier whilst we're enabling/upgrading it, so I think doing it before ESLint is reasonable.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1829618 - Enable Prettier on json files (automatic fixes). r?Mossop!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1829618 - Enable Prettier on json files (configuration changes). r?Mossop!

Depends on D176336

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1829618 - Enable Prettier on json files (manual test fixes). r?#devtools-reviewers!

Depends on D176336

Comment 4

[Mark Banner (:standard8)]

Greg, should tools/browsertime/ be in either ThirdPartyPaths.txt or Generated.txt? It looks like these changes would touch tools/browsertime/package.json but that appears to now being generated? Though the whole directory is maybe third party?

Comment 5

[Greg Mierzwinski [:sparky]]

Ah you're right, thanks for catching that! The package.json, and package-lock.json files in tools/browsertime are auto-generated when we update browsertime through ./mach browsertime --update-upstream-url <TARBALLL-COMMIT-LINK>. We should add those two files to Generated.txt.

Comment 6

[Mark Banner (:standard8)]

Thanks, I'll do that in these patches.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/319779e24a77
Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/867749fa570b
Enable Prettier on json files (configuration changes). r=mossop
https://hg.mozilla.org/integration/autoland/rev/8e7811d8eb96
Enable Prettier on json files (manual test fixes). r=devtools-reviewers,jdescottes

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d650dec9637
Fix Linting . CLOSED TREE

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/319779e24a77
https://hg.mozilla.org/mozilla-central/rev/867749fa570b
https://hg.mozilla.org/mozilla-central/rev/8e7811d8eb96
https://hg.mozilla.org/mozilla-central/rev/5d650dec9637