1829682 - Juno Onboarding cannot be vertically scrolled

Status: VERIFIED FIXED

(Firefox for Android :: Onboarding, defect, P1)

Description

[Rahul Sainani [:rsainani]]

Steps to reproduce

1. Open fenix nightly as new user (data cleared in device's app settings) on a smaller device like Moto G5 or Nexus 4.
2. Observe Juno onboarding's first page. The secondary button isn't visible and the screen cannot be vertically scrolled.

Expected behavior

The screen should be vertically scrollable.

Actual behavior

The screen is not vertically scrollable.

Device information

Nexus 4 Emulator / Moto G5 for [:cpeterson]

• Firefox version: 114
• Android device model: Nexus 4 Emulator
• Android OS version: 33

Any additional information?

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1829682 - Fix onboarding vertical scroll (#1761)

Comment 2

[Delia Pop (Android QA)]

Updating the Block field, since by previous comment in the meta ticket overwrite the update.

Comment 3

[Rahul Sainani [:rsainani]]

Joe, I'd like to request uplift to Beta 113 for this bug, once this is qe verified.

Comment 4

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/589e3fc21ce2796194f57d6fc3b7d44aadcb2545
[main] Bug 1829682 - Fix onboarding vertical scroll

Comment 5

[Joe M [:jmahon]]

Yep, uplift after verification sounds good

Comment 7

[Mira Lobontiu (Android QA)]

Attachment: 1829682.png

Verified as fixed on the latest Fenix Nightly 114.0a1 from 4/25 with a Xiaomi Mi4i (Android 5.0.2).
The first card is scrollable and actionable.

Comment 8

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1829682 - Fix onboarding vertical scroll (backport #1761) (#1772)

Comment 9

[Rahul Sainani [:rsainani]]

Comment on attachment 9330157 [details] [review]
[mozilla-mobile/firefox-android] Bug 1829682 - Fix onboarding vertical scroll (backport #1761) (#1772)

Beta/Release Uplift Approval Request

• User impact if declined: Users with small screen devices might not be able to see one or both the buttons and might not be able to progress in Onboarding and to the app.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Covered in the bugs's STR
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a minor fix for the scrollibility of the UI
• String changes made/needed: no
• Is Android affected?: Yes

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9330157 [details] [review]
[mozilla-mobile/firefox-android] Bug 1829682 - Fix onboarding vertical scroll (backport #1761) (#1772)

Approved for 113.0b8.

Comment 11

[BMO Github Automation]

Authored by https://github.com/rahulsainani
https://github.com/mozilla-mobile/firefox-android/commit/7b1e1fd65c82ea408d357657d63700aa4e995987
[releases_v113] Bug 1829682 - Fix onboarding vertical scroll

Comment 12

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Beta 113.0b8 with a Xiaomi Mi4i (Android 5.0.2).
The first card is scrollable and actionable.