Closed Bug 1829775 Opened 3 years ago Closed 3 years ago

add ssl context to urllib requests in tooltool

Categories

(Testing :: General, task)

Default
task

Tracking

(firefox114 fixed)

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

Details

Attachments

(1 file)

when running mozbase unittests on windows 11 (with upgraded python/mozbuild/etc.) we find that the tests fail with SSL errors.

Adjusting the calls to urllib.urlopen() to include context of the ssl cert, will solve this problem.

Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38227bde6465 add ssl cert context to urlopen in tooltool.py. r=glandium

Backed out for causing docker images failure

Backout link

Push with failures

Failure log

Flags: needinfo?(jmaher)

thanks, I have a patch up for review!

Flags: needinfo?(jmaher)
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ee5a72168b9 add ssl cert context to urlopen in tooltool.py. r=jcristau
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: