1829822 - lando redirects to the wrong patch after going through auth0

Status: RESOLVED FIXED

(Conduit :: Lando, defect, P3)

Description

[Julien Cristau [:jcristau] (back August 18)]

Attachment: screenshot from network devtools

A lot of the time when I hit the "view stack in lando" link in phabricator, it takes me to the wrong patch stack, typically the previous one I'd opened in lando. If I go back to phabricator and click the link again, it goes to the right place
I've finally managed to remember to open devtools before doing that yesterday, and it looks like what happens is lando redirects to auth0, which then redirects back to lando, and at that point its state is confused and the final redirect goes to the wrong page. When things work, presumably there's a new-enough auth token and lando doesn't redirect, so we stay on the correct page.

Comment 1

[Zeid [:zeid]]

Most likely this is an issue with the oidc_error handler.

Comment 2

[Zeid [:zeid]]

This will be fixed when auth related functionality is refactored as part of bug 1863756.

Comment 3

[Connor Sheehan [:sheehan]]

This issue should no longer occur in the new Lando, since we are not using the same Flask OIDC handler.