1830006 - build failure because of missing malloc.h since skia m113 update

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Landry Breuil (:gaston)]

my builds of m-c on OpenBSD started failing 9 or 10 days ago, cf http://buildbot.rhaalovely.net/nine/#/builders/3 & http://buildbot.rhaalovely.net/nine/#/builders/3/builds/1671/steps/8/logs/stdio for the full log, but the gist is:

56:06.72 In file included from Unified_cpp_gfx_skia0.cpp:38:
56:06.72 In file included from /build/buildslave-amd64/mozilla-central-amd64/build/gfx/skia/skia/src/base/SkContainers.cpp:18:
56:06.72 /build/obj/buildslave/mozilla-central/dist/system_wrappers/malloc.h:3:15: fatal error: 'malloc.h' file not found
56:06.72 #include_next <malloc.h>
56:06.72               ^~~~~~~~~~
56:08.00 1 error generated.

the failing codepath is probably https://searchfox.org/mozilla-central/source/gfx/skia/skia/src/base/SkContainers.cpp#17 because of defined(SK_BUILD_FOR_UNIX).

maybe there should be a check for !OpenBSD (because there's no such malloc.h) or if there's an actual malloc.h ? i dont see a check for it in the moz.configure plumbing ?

cf bug #1112249 for a previous similar bug.

Comment 1

[Landry Breuil (:gaston)]

fwiw there's no such thing as malloc_usable_size on OpenBSD.

our various chromium variant ports all use this patch: https://github.com/openbsd/ports/blob/master/www/chromium/patches/patch-third_party_skia_src_base_SkContainers_cpp

would it be upstreamable in mozilla-central ?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1821512

:lsalzman, since you are the author of the regressor, bug 1821512, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: Bug 1830006 - Do not use malloc.h on OpenBSD. r?aosmond

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e632b49ccc4
Do not use malloc.h on OpenBSD. r=aosmond

Comment 5

[Landry Breuil (:gaston)]

thanks :lsalzman ! i had a similar diff in my tree.

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6e632b49ccc4