1830054 - Tracking Protection is not deactivated in private window

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[nicoleta.sibisan]

Found in

• 113.0b8

Tested platforms

• Affected platforms: win 10, Win 11, MacOs 12, ubuntu 22

Steps to reproduce

1. Access the about:preferences#privacy page.
2. Click the "Custom" radio button from the "Enhanced Tracking Protection" section.3.
3. Uncheck the "Tracking content" checkbox.
4. Uncheck the "Cookies" checkbox.
5. Uncheck "Cyrptominers" and "Fingerprinters"
6. Open a new private browsing session.
7. Access the following website http://edition.cnn.com/
8. Click on the shield icon from the URL bar.

Expected result

• The shield icon is displayed near the address bar, with a gray outline.
• Tracking Content is displayed with a "Allowed" status.

Actual result

• The shield icon is displayed near the address bar, with a blue outline.
• Tracking Content is displayed with a "Blocked" status.

Regression range

• First bad: 2023-03-09
• Last good: 2023-03-08
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b20918f8f6084f291745aada1a4e15c861b76cca&tochange=08fb1f9a395b5384418342c7531717e3426e9f92
• Potentially regressed by: bug 1819662

Comment 1

[Mihai Popa [:papermario]]

Should you attach a screenshot (expected and actual results)? If yes, attach it!

Comment 2

[nicoleta.sibisan]

Attachment: tracking-content-status2023-04-26.png

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:timhuang, since you are the author of the regressor, bug 1819662, could you take a look?

For more information, please visit auto_nag documentation.

Comment 4

[Tim Huang[:timhuang]]

This is because the email tracker blocking is currently using the Tracking Content to show the blocked email trackers. I think we have to disable the email tracker blocking as the Tracking Content is disable on the Custom UI.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1819662

Comment 6

[Tim Huang[:timhuang]]

Attachment: Bug 1830054 - Disable Email tracking protection if tracking protection is disabled on the ETP Custom UI. r?#anti-tracking-reviewers

We surface the email tracking protection using the existing tracking
protection UI on the protection panel, but we don't disable email
tracking protection if tracking protection is disabled. So, users will
still see blocked trackers if tracking protection is disabled for
private windows. To provide a way to disable email tracking protection
in private windows, we also use the existing tracking protection checkbox
UI to disable the email tracking protection.

This patch implements that disabling the tracking protection via the
tracking protection checkbox also disables email tracking protection.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6e929080568
Disable Email tracking protection if tracking protection is disabled on the ETP Custom UI. r=anti-tracking-reviewers,pbz

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a6e929080568

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:timhuang, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Tim Huang[:timhuang]]

Comment on attachment 9332419 [details]
Bug 1830054 - Disable Email tracking protection if tracking protection is disabled on the ETP Custom UI. r?#anti-tracking-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: In private browsing windows, users will still see blocked trackers even if the tracking protection is disabled via ETP Custom settings page on about:preferences.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a low risk change because it only changes the behavior when user unchecks the Tracking Content checkbox.
• String changes made/needed: None
• Is Android affected?: No

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9332419 [details]
Bug 1830054 - Disable Email tracking protection if tracking protection is disabled on the ETP Custom UI. r?#anti-tracking-reviewers

Approved for 114.0b7.

Comment 12

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/07ce06545121

Comment 13

[nicoleta.sibisan]

Verified - fixed on MacOS 12, Win 11 and Ubuntu 22.04 in Fx versions 114.0b7 and 115.0a1 (2023-05-21)