1830192 - Auto-height block container wrongly draws block-end border with max-height constraint

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

See the last subtest of Bug 1828977 testcase 2.

Quote Daniel's observation in bug 1828977 comment 4:

Firefox unnecessarily (?) draws a thin strip of the container in the second column, followed by the border-bottom in the 3rd column.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1830192 - Fix fragmentation for blocks with auto height and fixed max-height.

Nowadays BlockReflowState::BorderPadding() won't skip the block-end border and
padding [1] because we use PreReflowBlockLevelLogicalSkipSides() which always
assume the current fragment is the last fragment. Therefore, This change removes
the note and retrieve block-end BP directly from borderPadding, which is an
alias of BlockReflowState::BorderPadding().

The only difference between the added test and reference file are height and
max-height, so the test verifies the fragmentation are consistent internally.

[1] https://searchfox.org/mozilla-central/rev/0ffaecaa075887ab07bf4c607c61ea2faa81b172/layout/generic/BlockReflowState.cpp#46

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df519de7261a
Fix fragmentation for blocks with auto height and fixed max-height. r=dholbert

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39917 for changes under testing/web-platform/tests

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/df519de7261a

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot