Wrong screen impression sent after switching locale and reload of about:welcome
Categories
(Firefox :: Messaging System, defect, P2)
Tracking
()
People
(Reporter: pdahiya, Unassigned)
References
(Blocks 1 open bug)
Details
Followup of https://bugzilla.mozilla.org/show_bug.cgi?id=1823779 fix tracking below edge case
STR:
- Open about:welcome with Language Switcher flow
- Switch locale on Language switcher screen
- Hit Reload or complete onboarding by navigating to about:home and hit back button
- Screen impression in telemetry ping are incorrect
This only happens on about:welcome reloads due to explicit click of refresh or back navigation from about:home to about:welcome due to filtering out AW_LANGUAGE_MISMATCH
screen in useLanguageSwitcher custom hook and updating screen index , while useEffect hook that sends impression ping still using upcomingScreens from defaultScreens to get filteredScreens
let upcomingScreens = defaultScreens.filter(
s => !screensVisited.find(v => v.id === s.id)
);
let filteredScreens = screensVisited.concat(
(await window.AWEvaluateScreenTargeting(upcomingScreens)) ??
upcomingScreens
);
`
One option to fix is maintaining defaultLanguageModifiedScreens
state thats gets updated if useLanguageSwitcher
custom hook filter AW_LANGUAGE_MISMATCH
and using that instead of defaultScreens.
Reporter | ||
Updated•11 months ago
|
Comment 1•11 months ago
|
||
The severity field is not set for this bug.
:tspurway, could you have a look please?
For more information, please visit BugBot documentation.
Comment 2•10 months ago
|
||
Redirect a needinfo that is pending on an inactive user to the triage owner.
:lsmith, since the bug has recent activity, could you have a look please?
For more information, please visit BugBot documentation.
Reporter | ||
Updated•10 months ago
|
Description
•