Closed Bug 1830324 Opened 2 years ago Closed 2 years ago

Make Project Search use Tree instead of ManagedTree

Categories

(DevTools :: Debugger, task)

task

Tracking

(firefox115 fixed)

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

Project search doesn't really use anything meaningful from ManagedTree.
It depends on some CSS of it, but nothing from the React implementation.
The few bits implemented in ManagedTree is specific to the SourcesTree and especially highlighted items. This can easily be merged into SourcesTree once we remove the only distinct user of ManagedTree.

The ManagedTree subclass is really only relevant to SourcesTree
and could be folded up into SourcesTree.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Blocks: 1831149
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d7d33fcdb69 [devtools] Make ProjectSearch use Tree instread of ManagedTree. r=devtools-reviewers,bomsy
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch

== Change summary for alert #38443 (as of Wed, 24 May 2023 08:04:25 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
6% damp custom.jsdebugger.project-search.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 1,135.71 -> 1,063.80
4% damp custom.jsdebugger.project-search.DAMP windows10-64-shippable-qr e10s fission stylo webrender-sw 995.02 -> 953.12
4% damp custom.jsdebugger.project-search.DAMP windows10-64-shippable-qr e10s fission stylo webrender 1,001.82 -> 960.68

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=38443

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: