Closed Bug 1830333 Opened 1 year ago Closed 1 year ago

Make toggle focusable and clickable via keyboard in PanelMultiView

Categories

(Firefox :: Toolbars and Customization, task, P1)

task

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: hjones, Assigned: hjones)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(1 file)

There's a lot of custom focus and keyboard event management logic in PanelMutliView.jsm, some of which interferes with the expected behaviour of moz-toggle when we try to use it in a panel. There's probably some more comprehensive work to do here to change how PanelMultiView.jsm handles HTML elements in general, but this bug will just cover the work involved in making sure moz-toggle works as expected.

This is a quick fix to unblock some onging work to use moz-toggle in the chrome. I'll follow up by filing a bug to reevaluate focus management in PanelMultiView more generally.

Component: XUL Widgets → Toolbars and Customization
Product: Toolkit → Firefox

taking a guess at priority and severity; feel free to correct me :-)

Severity: -- → S2
Priority: -- → P1
Whiteboard: [fidefe-reusable-components]
See Also: → 1831348
Pushed by hjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe60b559a8e3
special case moz-toggle handling in panel multi view r=mstriemer,Gijs
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
Whiteboard: [fidefe-reusable-components] → [recomp]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: