1830547 - Reader mode should update to system light/dark mode while it is in use

Status: RESOLVED WORKSFORME

(Firefox for Android :: General, enhancement, P3)

Description

[Erik Westrup]

Steps to reproduce:

Initial state: Android is set to light mode

1. Go to a website for which the Reader mode can be enabled, and enable it
2. Observe that the reader is using the light mode, can also confirm in the "Customize reader view" settings the current mode.
3. Change Android system mode to dark
4. Observe that the Reader view is still in the light view

Actual results:

The Reader view does now follow the system's dark/light mode, as it should (implemented).

Expected results:

The Reader view should follow the system, as in this PR that is merged. The PR description has a video that shows how it should work.

However for me the reader only changes to dark/light when I do so manually from the "Customize reader view" settings, never automatically depending on the system's mode.

https://github.com/mozilla-mobile/android-components/pull/12857

I see that the code from this PR is still in the new repo at:
https://github.com/mozilla-mobile/firefox-android/blob/b0580835a0d146beb746bd309fbb73c2365f022d/android-components/components/feature/readerview/src/main/java/mozilla/components/feature/readerview/internal/ReaderViewConfig.kt#L44-L49

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jonalmeida, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Jonathan Almeida [:jonalmeida]]

Converting this to an enhancement - the linked PR and changes will evaluate the system theme when colorScheme is called and does not observe when the system theme has changed.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1830547 - Added @Throws for AutofillCreditCardsAddressesStorage (#2261)

Comment 4

[Delia Pop (Android QA)]

Attachment: Google Pixel 8 Pro (Android 14).mp4

This issue is no longer reproducible in the latest releases with Google Pixel 8 Pro (Android 14). The reader mode adapts to the device's theme.