1830550 - The filter results info text in the quick filter bar turns green (from red) for "No results" with tags filter

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Sören Hentzschel]

STR:

1. Make sure that you don't have any tagged messages
2. Make sure that the quick filter bar is enabled
3. Press the button to show messages with tags

Actual:

The message that no messages were found appears in red and changes to green.

Expected:

The message keeps its red color.

Additional notes:

Similar to bug 1818204 (different feature of the quick filter bar, but also a color change of the status text). Before fixing bug 1828341 the color changed from red to grey, now from red to green.

Comment 1

[Thomas D. (:thomas8)]

Confirming for Daily 114.0a1 (2023-05-01) (64-bit), Win10. "No results" quick filter feedback flashes red for a split second, then turns green, which is wrong. Richard, can you have a look?

Comment 2

[Richard Marti (:Paenglab)]

This isn't a CSS issue. The #quick-filter-bar has correctly set filterActive="nomatches" but after a short time it switches to filterActive="searching" and stays in this state. Also successful searches end in filterActive="searching".

Comment 3

[Alessandro Castellani [:aleca]]

Yes, it seems we're updating the markup attribute too often even when things don't change.
I'll investigate and assign someone.

Comment 4

[Alessandro Castellani [:aleca]]

Apparently the matching attribute is wrongly updated when searching text alongside tags.
Upon investigating we also found that those colors are not accessible and not properly handling light/dark/HC mode variations.
It's safer to remove this code and only show the results count without any color.

Comment 5

[[e-mail]]

Attachment: Bug 1830550 - Remove color from quick filter results. r=#thunderbird-front-end-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/037ea96d7379
Remove color from quick filter results. r=freaktechnik