183078 - lose filtered folder name when migrating a 4.x profile

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[grylchan]

using commerical trunk
2002-12-02-08-trunk on xp

If you migrate a 4.x profile, you lose the destination folder
name where you want your filtered mesgs to go to. Everything
else gets migrated fine (filter name, criteria for the filter)
except the destination folder.

In my filter it shows 'Move to folder: Mail for <username>' instead
of 'Move to folder: x'.

I assume this is due to the new msgFilterRules.dat file since
Rules.dat got forked (bug 168553).


steps to reproduce
1.Create some filters for a 4.x profile (i'm using 4.8)
2.Install latest trunk
3.At the profile mgr screen select a 4.x profile with filters
4.Migrate it.
5.Open mail/news
6.Bring up filter window
7.select a filter and click edit button

result: mesgs won't be filterd to your destination folder and destination
   folder says 'Move to folder: Mail for <username>' 

expected: to have my folder name migrated over so the filters will work.

Comment 1

[grylchan]

nominating for next release since it would be pain
to mannually go into the filter UI and reset each folder again.

I was going to put 'dataloss' in keyword but it's not quite
that bad

Comment 2

[laurel]

*** Bug 191153 has been marked as a duplicate of this bug. ***

Comment 3

[Samir Gehani]

Mail triage team: nsbeta1+/adt2

Comment 4

[Cavin Song]

The problem is that nsMsgFilter::ConvertMoveToFolderValue() does not always call 
filterAction->SetTargetFolderUri() once it figures out the right folder uri. The 
migration code is fine as it only copies the 4.X rules.dat file over to the 7.X 
directory.

Comment 5

[Cavin Song]

Attachment: Proposed patch, v1

Always set folder uri in filter action object.

Comment 6

[(not reading, please use [e-mail] instead)]

what's the code path where we fail to call filterAction->SetTargetFolderUri()?

looking at ConvertMoveToFolderValue(), your patch will make to so we it twice
(in some cases).

this code was changed by navin for #174441 and #168553, how did his change cause
this?

Comment 7

[Cavin Song]

Attachment: Proposed patch, v2

One call to filterAction->SetTargetFolderUri() was missing from the true case
of the following test:

  if (moveValue.Find(kImapPrefix) == 0)

So put it back to where it was.

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 116160 [details] [diff] [review]
Proposed patch, v2

r/sr=sspitzer

nice work, cavin.

this was accidentally removed from the code.

Comment 9

[(not reading, please use [e-mail] instead)]

Comment on attachment 116160 [details] [diff] [review]
Proposed patch, v2

r/sr=sspitzer

nice work, cavin.

this was accidentally removed from the code.

Comment 10

[Cavin Song]

Fix checked in on 03/03.

Comment 11

[Ninoschka Baca]

Trunk build 2003-04-10: WinXP - ok.

Esther, can you check linux?

Cant check on the Mac since blocked by bug# 190336.

Comment 12

[Ninoschka Baca]

Trunk build 2003-04-10: Linux RH 7 (Esther's system)
The Mail/Settings and Address Books are migrated but the filters are gone (bug#
202010) which is a linux specific problem.

I'm blocked from verifying this bug due to bug 190336 and 202010.

Comment 13

[Ninoschka Baca]

Trunk build 2003-05-20: Mac 10.1.5, Linux RH 8
Verified Fixed (checked IMAP and POP profiles)