1830816 - Convert JSMs in browser/tools/mozscreenshots/mozscreenshots/extension to ESMs

Status: RESOLVED FIXED

(Testing :: mozscreenshots, task)

Description

[kpatenio]

As a part of ESMification efforts, there are 15 JSMs requiring conversion in browser/tools/mozscreenshots . Also see areweesmifiedyet .

Given the number of modules to convert, the work can probably be broken down into separate tickets for select modules.

Comment 1

[kpatenio]

Attachment: Bug 1830816 - Convert JSMs in browser/tools/mozscreenshots/mozscreenshots/extension to ESMs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73b7fefcfc45
Convert JSMs in browser/tools/mozscreenshots/mozscreenshots/extension to ESMs. r=Standard8

Comment 3

[Iulian Moraru]

Backed out for causing mochitest failures on browser_controlCenter.js.

• Push with failures

• Failure log

• Backout link

[task 2023-05-08T17:09:18.100Z] 17:09:18     INFO - TEST-START | browser/tools/mozscreenshots/controlCenter/browser_controlCenter.js
[task 2023-05-08T17:09:18.104Z] 17:09:18     INFO - installing extension temporarily
[task 2023-05-08T17:09:18.160Z] 17:09:18     INFO - Checking for mozscreenshots extension
[task 2023-05-08T17:09:18.166Z] 17:09:18     INFO - TEST-PASS | browser/tools/mozscreenshots/controlCenter/browser_controlCenter.js | The mozscreenshots extension should be installed - 
[task 2023-05-08T17:09:18.168Z] 17:09:18     INFO - Leaving setup bound setup
[task 2023-05-08T17:09:18.170Z] 17:09:18     INFO - Entering test bound capture
[task 2023-05-08T17:09:18.171Z] 17:09:18     INFO - Saving screenshots to: /tmp/mozscreenshots/2023-05-08T17-09-18.169Z_Linux
[task 2023-05-08T17:09:18.178Z] 17:09:18     INFO - TEST-INFO | started process screentopng
[task 2023-05-08T17:09:18.356Z] 17:09:18     INFO - TEST-INFO | screentopng: exit 0
[task 2023-05-08T17:09:18.358Z] 17:09:18     INFO - Buffered messages logged at 17:09:18
[task 2023-05-08T17:09:18.358Z] 17:09:18     INFO - Entering setup bound setup
[task 2023-05-08T17:09:18.359Z] 17:09:18     INFO - Buffered messages finished
[task 2023-05-08T17:09:18.361Z] 17:09:18     INFO - TEST-UNEXPECTED-FAIL | browser/tools/mozscreenshots/controlCenter/browser_controlCenter.js | Uncaught exception in test bound capture - at resource://mozscreenshots/TestRunner.sys.mjs:96 - Error: Failed to load resource://mozscreenshots/Screenshot.jsm
[task 2023-05-08T17:09:18.361Z] 17:09:18     INFO - Stack trace:
[task 2023-05-08T17:09:18.361Z] 17:09:18     INFO - start@resource://mozscreenshots/TestRunner.sys.mjs:96:5
[task 2023-05-08T17:09:18.362Z] 17:09:18     INFO - capture@chrome://mochitests/content/browser/browser/tools/mozscreenshots/controlCenter/browser_controlCenter.js:15:20
[task 2023-05-08T17:09:18.362Z] 17:09:18     INFO - handleTask@chrome://mochikit/content/browser-test.js:1133:26
[task 2023-05-08T17:09:18.362Z] 17:09:18     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1205:18
[task 2023-05-08T17:09:18.362Z] 17:09:18     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1347:14
[task 2023-05-08T17:09:18.362Z] 17:09:18     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1122:14
[task 2023-05-08T17:09:18.362Z] 17:09:18     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-05-08T17:09:18.363Z] 17:09:18     INFO - Leaving test bound capture
[task 2023-05-08T17:09:18.576Z] 17:09:18     INFO - GECKO(1580) | JavaScript error: resource://gre/modules/XULStore.sys.mjs, line 60: Error: Can't find profile directory.
[task 2023-05-08T17:09:18.601Z] 17:09:18     INFO - GECKO(1580) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2023-05-08T17:09:18.606Z] 17:09:18     INFO - GECKO(1580) | MEMORY STAT | vsize 11434MB | residentFast 480MB | heapAllocated 238MB
[task 2023-05-08T17:09:18.606Z] 17:09:18     INFO - TEST-OK | browser/tools/mozscreenshots/controlCenter/browser_controlCenter.js | took 493ms
[task 2023-05-08T17:09:18.670Z] 17:09:18     INFO - checking window state
[task 2023-05-08T17:09:18.718Z] 17:09:18     INFO - GECKO(1580) | Completed ShutdownLeaks collections in process 1580
[task 2023-05-08T17:09:18.720Z] 17:09:18     INFO - TEST-START | Shutdown
[task 2023-05-08T17:09:18.721Z] 17:09:18     INFO - Browser Chrome Test Summary
[task 2023-05-08T17:09:18.722Z] 17:09:18     INFO - Passed:  1
[task 2023-05-08T17:09:18.723Z] 17:09:18     INFO - Failed:  1
[task 2023-05-08T17:09:18.723Z] 17:09:18     INFO - Todo:    0
[task 2023-05-08T17:09:18.724Z] 17:09:18     INFO - Mode:    e10s
[task 2023-05-08T17:09:18.725Z] 17:09:18     INFO - *** End BrowserChrome Test Results ***

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44c2c28f9d43
Convert JSMs in browser/tools/mozscreenshots/mozscreenshots/extension to ESMs. r=Standard8

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/44c2c28f9d43