Where is the --disable-hardening option?
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
People
(Reporter: chrisxuche, Unassigned)
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/113.0
Steps to reproduce:
I'm reading build/moz.configure/toolchain.configure to figure out what actually the hardening option does. On line 2374, it says: "... if --disable-hardening is passed ...", but I don't see any code defined or related to the --disable-hardening option.
I'm not familiar with the build system, so I wonder if the comment is not up to date, or the option is defined in somewhere else?
|
||
Comment 1•2 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
||
Updated•2 years ago
|
|
||
Comment 2•2 years ago
•
|
||
The code is right above the comment: https://searchfox.org/mozilla-central/source/build/moz.configure/toolchain.configure#2366-2370
It's not intuitive, but in configure --enable-* and --disable-* are referring to the same '*', but true/false states. I think 'best practice' is to always use --enable-* to minimize confusion, but that's what the comment is trying to say, that this behavior is confusing.
|
|
||
Updated•2 years ago
|
I didn't know that --enable-* and --disable-* refer to the same * before, so I was confused when I only saw the definition of --enable-hardening. Thank you for your answer!
|
|
||
Comment 4•2 years ago
•
|
||
No problem! In the future, I'd recommend asking a question like this on the #build matrix channel (or maybe even #developers), and wait to raise a bug until there's something actionable to do.
Description
•