1831137 - Turn on resident key support on GeckoView

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, enhancement, P2)

Description

[Makoto Kato [:m_kato]]

Actually, GeckoView uses Google's FIDO2 library. But when using resident key, it will be synced as Passkey via Google's password manager at force.

• There is no option that we doesn't use Google's password manager / account. If not signed in, it causes "Can't create passkey" error.
  • I filed feature request as https://issuetracker.google.com/issues/277974244
• Android 14 may be able to use other password manager via Credential Provider service. But no way to test now. If Google allows 3rd party account, we may be able to turn on this on Android 14+.
• When using OS's WebAuthn support, we have to consider whether we allow Passkey via OS's account (In Windows, Microsoft account. In macOS, iCloud account, In Android, Google account)

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 1831137 - Enable creation of Passkeys on Android. r=dveditz

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84f28be8ef2d
Enable creation of Passkeys on Android. r=dveditz

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/84f28be8ef2d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Should this get a callout in the Fx128 relnotes?

Comment 6

[John Schanck [:jschanck]]

Yes, but Bug 1862132 is the main feature, so I added the relnote request there.

Comment 7

[Florin Bilt]

(In reply to Pulsebot from comment #3)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84f28be8ef2d
Enable creation of Passkeys on Android. r=dveditz

Hello, the following alert seems to be very noisy but I think it could be caused by this bug. Please let us know if you think this bug could cause this regression.

Perfherder has detected a build_metrics performance change from push cd09151a1c46cba9d56b45684eebc6465a5e869c.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.13%	installer size	osx-aarch64-shippable	aarch64 nightly	92,055,786.08 -> 92,175,068.50

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 632

For more information on performance sheriffing please see our FAQ.

Comment 8

[John Schanck [:jschanck]]

This patch was not responsible for the installer size change. It flipped the value of a pref, and did not add or remove any code or data.