1831140 - [wpt-sync] Sync PR 39824 - Reland "Storage buckets: make Bucket File System aware of quota limit"

Status: RESOLVED FIXED

(Core :: DOM: File, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39824 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39824
Details from upstream follow.

Evan Stade <[e-mail]> wrote:

Reland "Storage buckets: make Bucket File System aware of quota limit"

This reverts commit 5d667161bd35c3ead343b9b4b38ed5edf9818231.

Reason for revert: build fixed in ps2

Original change's description:

Revert "Storage buckets: make Bucket File System aware of quota limit"

This reverts commit 478714b5b29230c1974a4b2378b2f7582fd11dd6.

Reason for revert:
LUCI Bisection identified this CL as the culprit of a build failure. See the analysis: https://luci-bisection.appspot.com/analysis/b/8782164710170685953

Sample failed build: https://ci.chromium.org/b/8782164710170685953

If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fluci-bisection.appspot.com%2Fanalysis%2Fb%2F8782164710170685953&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F4494605

Original change's description:

Storage buckets: make Bucket File System aware of quota limit

Bug: 1315396
Change-Id: I830fa2f0d4841458d48dffb053850d704cbbbe9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4494605
Reviewed-by: Austin Sullivan \<[e-mail]>
Commit-Queue: Evan Stade \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1138703}

Bug: 1315396
Change-Id: Iaa3174bf065758c0baeab849fe86d3c27baaea79
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4501071
Owners-Override: [e-mail] \<[e-mail]>
Commit-Queue: [e-mail] \<[e-mail]>
Bot-Commit: [e-mail] \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1138718}

Bug: 1315396
Change-Id: Iccf00ca00750f17bd6d1c870da4b257c6f1dac7b

Reviewed-on: https://chromium-review.googlesource.com/4500652
WPT-Export-Revision: 341e3a9ab5197bc4cfb2092e4ad375eba59dfdc2

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd70e6021571db4a66fb9949ffd317e1cf41d02e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Try push failed: decision task H7euqJWrRziiOZF74x8qPw returned error

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e937dad8bf44a24d252c8b9a2e0c69d829a51cb6

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

OK : 2
FAIL: 6

Chrome

OK : 2
PASS: 4
FAIL: 2

Safari

OK : 2
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fs/FileSystemBaseHandle-buckets.https.any.html [wpt.fyi]
  • isSameEntry works as expected with buckets: FAIL (Chrome: PASS, Safari: FAIL)
  • getDirectory promise rejects if bucket has been deleted: FAIL (Chrome: PASS, Safari: FAIL)
  • Bucket quota restricts the size of a file that can be created: FAIL (Chrome: FAIL, Safari: FAIL)
• /fs/FileSystemBaseHandle-buckets.https.any.worker.html [wpt.fyi]
  • isSameEntry works as expected with buckets: FAIL (Chrome: PASS, Safari: FAIL)
  • getDirectory promise rejects if bucket has been deleted: FAIL (Chrome: PASS, Safari: FAIL)
  • Bucket quota restricts the size of a file that can be created: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e06266260d94
[wpt PR 39824] - Reland "Storage buckets: make Bucket File System aware of quota limit", a=testonly
https://hg.mozilla.org/integration/autoland/rev/0646fcedc81d
[wpt PR 39824] - Update wpt metadata, a=testonly

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e06266260d94
https://hg.mozilla.org/mozilla-central/rev/0646fcedc81d