1831155 - [wpt-sync] Sync PR 39825 - Fix painting order of text-shadow on (underline) decorations

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39825 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39825
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Fix painting order of text-shadow on (underline) decorations

The right-most shadow should be at the bottom, so needs to be painted
first (c.f. TextPainterBase::CreateDrawLooper()).

Iterate the text-shadow vector in reverse in
NGTextPainterBase::PaintUnderOrOverLineDecorationShadows().

Fixed: 1442188
Change-Id: I02e0b9909d8280b3e893ca0c58225ae5dca94ace

Reviewed-on: https://chromium-review.googlesource.com/4499286
WPT-Export-Revision: 00ae2efa1d5f97abff41f19dd42d73a055c581f2

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=719ea3edd12d004274590378ee8a360e5498fa8a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Try push failed: decision task faVl3vV2TiGYDtBV3maGwQ returned error

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3267fae1f8bd5f5b657f42674d6d752aa258e7cb

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cfc1d883f03
[wpt PR 39825] - Fix painting order of text-shadow on (underline) decorations, a=testonly

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2cfc1d883f03