Open Bug 1831163 Opened 1 year ago Updated 3 months ago

Make WebRTC configure new options with OpenH264 2.3.2

Categories

(Core :: Audio/Video: GMP, enhancement, P3)

enhancement

Tracking

()

ASSIGNED

People

(Reporter: aosmond, Assigned: aosmond)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

We can now set the H264 profile, level and multithreaded encoding when we get the updated library. If we don't bump the API version in the struct, we will get the same behaviour as before.

This patch allows WebRTC to configure the OpenH264's encoder H264
profile and level, as well as multithreaded encoding. By default this is
turned off, and we can turn it on once we validate the library update.

The multithreaded encoding saw a ~15% performance improvement with
Chrome. See this bug for details:
https://bugs.chromium.org/p/chromium/issues/detail?id=1397287

Pushed by aosmond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da811f1b9389
Allow WebRTC encoder to configure new OpenH264 options. r=webrtc-reviewers,pehrsons

Backed out for causing mda failures in test_peerConnection_basicH264Video.html

Flags: needinfo?(aosmond)

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:aosmond, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(apehrson)
Flags: needinfo?(aosmond)
Flags: needinfo?(apehrson)
Flags: needinfo?(aosmond)
Flags: needinfo?(aosmond)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: