1831286 - Configure option --enable-perf causes jit-test failures.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P2)

Description

[Nicolas B. Pierron [:nbp]]

Currently, running the jit-test with a build configured using --enable-perf yields 314 failures.

One problem which is not highlighted by the test suite, is that if we have any differential behavior such as a Segmentation Fault, then we might have other forms of differential behavior which might suggest that the performance profiles collected are no longer representative of the ordinary behavior.

Thus, either we should fix it our implementation of this instrumentation, or remove it as it might not be representative.

Comment 1

[Denis Palmeiro [:denispal]]

Attachment: Bug 1831286: Handle OOM during interpreter entry trampoline generation. r=iain!

Comment 2

[Denis Palmeiro [:denispal]]

Attachment: Bug 1831286: Handle interpreter entry frame separately than rectifier in the profiler exit tail. r=iain!

We are missing a check for rectifier->blinterp entry. This change should be functionally the same as before but I seperated out the checks for rectifier and baseline interpreter entry so it's easier to read.

Depends on D195476

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc9ff49f0375
Handle OOM during interpreter entry trampoline generation. r=iain
https://hg.mozilla.org/integration/autoland/rev/f3c421ea4016
Handle interpreter entry frame separately than rectifier in the profiler exit tail. r=iain

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/fc9ff49f0375
https://hg.mozilla.org/mozilla-central/rev/f3c421ea4016