1831332 - DDG non-organic searches are not reported correctly in telemetry

Status: VERIFIED FIXED

(Firefox :: Search, defect, P2)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: DDG codes

Found in

• Fx 114.0a1

Affected versions

• Fx 114.0a1
• Fx 113.0b9

Affected platforms

• Windows 10
• Ubuntu 20
• macOS

Steps to reproduce

1. Launch Firefox.
2. Navigate to duckduckgo.com.
3. Perform a search using the DDG websearch from the DDG website.
4. Open a new tab and navigate to about:telemetry.
5. Open the RAW json -> raw data and search for the browser.search.content.unknown ping.

Expected result

• The ping exists and has the following value: duckduckgo:organic:none": 1.

Actual result

• The listed ping has the following value: duckduckgo:organic:other": 1

Regression range

• Not a Firefox regression as the search codes were added/changed by DDG.

Comment 1

[Mark Banner (:standard8)]

We've seen DDG using some new codes that we'll need to count as expected organic. The ones we've seen so far are hg, hh, hi and hj.

Comment 2

[Mark Banner (:standard8)]

I've now added the four new codes to remote-settings on staging & they have been approved. Please can QA test.

Comment 3

[Cristian Baica [:cbaica], Release Desktop QA]

Tested on staging on Windows 10, Ubuntu and macOS using the latest nightly and beta builds. Codes are correctly reported as organic:none when encountered.

Comment 4

[Mark Banner (:standard8)]

Reminder to myself.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1831332 - Update DDG telemetry codes.

Comment 6

[Mark Banner (:standard8)]

Patch attached for posterity. It is now on production-preview ready for final approval.

Comment 7

[Mark Banner (:standard8)]

This is now on production as of 14:58 today.

Comment 8

[Mark Banner (:standard8)]

Attachment: Bug 1831332 - Fix test_urlTelemetry.js to not use a code for the organic:other test that is likely to be an organic:none in the future. r?jteow!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2236e82a4ee2

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/9ac56614e356

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86abd9c9d02e
Fix test_urlTelemetry.js to not use a code for the organic:other test that is likely to be an organic:none in the future. r=jteow

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/c84952630407

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/86abd9c9d02e

Comment 14

[Cristian Baica [:cbaica], Release Desktop QA]

Closing the issue as verified fixed.
Please note that DDG changed the codes again, causing the same issue to happen again. Tracked in bug 1851125.