Closed Bug 1831416 Opened 3 years ago Closed 3 years ago

Update the test with fragment of import.meta.url in dedicated-worker-import-meta.html

Categories

(Testing :: web-platform-tests, defect)

Default
defect

Tracking

(firefox115 fixed)

RESOLVED FIXED
115 Branch
Tracking Status
firefox115 --- fixed

People

(Reporter: allstars.chh, Assigned: allstars.chh)

Details

Attachments

(1 file)

(In reply to Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] from comment #0)

The wpt test
https://searchfox.org/mozilla-central/rev/85b4f7363292b272eb9b606e00de2c37a6be73f0/testing/web-platform/tests/workers/modules/dedicated-worker-import-meta.html#56
looks wrong, the expected URL should contain the fragment '#1', however the test expects the import.meta.url shouldn't contain the fragment.

That was my guess. I queried this with Domenic who wrote the test: https://github.com/web-platform-tests/wpt/pull/10717#issuecomment-1535918639

(In reply to Jon Coppeard (:jonco) from comment #2)
Reply from Domenic:

@jonco3 yes, I can't understand why we wrote the tests that way. It looks exactly wrong. Please feel free to open a PR to fix it.

Pushed by allstars.chh@gmail.com: https://hg.mozilla.org/integration/autoland/rev/fbb19ed18dab Update the test with fragment of import.meta.url in dedicated-worker-import-meta.html. r=jonco
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39965 for changes under testing/web-platform/tests
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: