1831422 - `Choose a password to backup your OpenPGP key` dialog opens with much empty space on the right; password inputs have different size and position

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect, P3)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot: Odd whitespace and element positioning on the dialog

Choose a password to backup your OpenPGP key dialog opens with much empty space on the right; password inputs have different size and position (see screenshot). Cosmetic issue, but looks odd.

STR

1. Tools > OpenPGP Manager
2. Select existing key (or Generate > New Key Pair)
3. File > Backup Secret Key(s) to File
4. In Export Secret and Public Key To File dialog, choose Save.
5. Check out the layout of the subsequent Choose a password to backup your OpenPGP Key dialog

Actual (see screenshot)

• Dialog opens with much empty space on the right
• Password inputs have different size and position (see screenshot)

Expected

• Align both password inputs
• Remove unused whitespace on the right

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1831422 - Fix "Choose a password to backup your OpenPGP key" layout issues. r=freaktechnik,kaie

Depends on D180757

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: backup-after.png

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/44423c5e555a
Fix "Choose a password to backup your OpenPGP key" layout issues. r=freaktechnik,kaie

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9338780 [details]
Bug 1831422 - Fix "Choose a password to backup your OpenPGP key" layout issues. r=freaktechnik,kaie

[Approval Request Comment]
User impact if declined: UI issues
Testing completed (on c-c, etc.): c-c, beta
Risk to taking this patch (and alternatives if risky): pretty safe

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9338780 [details]
Bug 1831422 - Fix "Choose a password to backup your OpenPGP key" layout issues. r=freaktechnik,kaie

[Triage Comment]
Approved for esr115

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 115.0.1:
https://hg.mozilla.org/releases/comm-esr115/rev/bec9e19a1ce4